From owner-svn-src-head@FreeBSD.ORG Fri Apr 17 16:06:57 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 951F7106567F; Fri, 17 Apr 2009 16:06:57 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 513888FC14; Fri, 17 Apr 2009 16:06:57 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 53E0E6D43F; Fri, 17 Apr 2009 16:06:56 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 1F982844C4; Fri, 17 Apr 2009 18:06:56 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Jack Vogel References: <200904141714.n3EHEZqZ014386@svn.freebsd.org> <49E4C927.2080508@freebsd.org> <2a41acea0904141044l49e6ef80hc23a740f02f85ce1@mail.gmail.com> Date: Fri, 17 Apr 2009 18:06:56 +0200 In-Reply-To: <2a41acea0904141044l49e6ef80hc23a740f02f85ce1@mail.gmail.com> (Jack Vogel's message of "Tue, 14 Apr 2009 10:44:44 -0700") Message-ID: <86ljpzmfhb.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Jack F Vogel , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Sam Leffler , src-committers@freebsd.org Subject: Re: svn commit: r191065 - head/sys/dev/e1000 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2009 16:06:58 -0000 Jack Vogel writes: > 2 SCTP specific bugs, one is a missing shift to correctly identify > SCTP type in the descriptor, the second was incorrectly assigning > rather than 'or-ing' the csum_flags, leading to the inability to do > other types of offload downstream. > > The third bug was more subtle, the code to detect a CRC fragment in > rxeof was being done at the wrong point, resulting in a crash/panic. This should go in the svn log. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no