From owner-cvs-all Tue Feb 25 8:20:21 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24FF537B401 for ; Tue, 25 Feb 2003 08:20:20 -0800 (PST) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF41D43FCB for ; Tue, 25 Feb 2003 08:20:16 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 783 invoked from network); 25 Feb 2003 16:20:19 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 25 Feb 2003 16:20:19 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h1PGJ3hT020075; Tue, 25 Feb 2003 11:19:04 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030225012409.GO27224@elvis.mu.org> Date: Tue, 25 Feb 2003 11:20:29 -0500 (EST) From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/boot/common ufsread.c Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, "David E. O'Brien" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 25-Feb-2003 Alfred Perlstein wrote: > * David E. O'Brien [030224 16:10] wrote: >> obrien 2003/02/24 16:10:20 PST >> >> Modified files: >> sys/boot/common ufsread.c >> Log: >> Only apply rev 1.10 (which hacks around the i386 boot2 being too big for >> both ufs1 and ufs2 support) on i386. > > Wouldn't it be possible to add a dependancy to "all" (possibly) that > would compare the size of the generated binary to something and cause > the target to fail if it was too big? > > This could catch such things early. That's pretty much what happened. It prints out how many bytes over it is and then fails. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message