From owner-freebsd-bugs@FreeBSD.ORG Fri Aug 8 14:50:05 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A8D8106569F for ; Fri, 8 Aug 2008 14:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 08BC28FC15 for ; Fri, 8 Aug 2008 14:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m78Eo4dl068922 for ; Fri, 8 Aug 2008 14:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m78Eo4RX068921; Fri, 8 Aug 2008 14:50:04 GMT (envelope-from gnats) Date: Fri, 8 Aug 2008 14:50:04 GMT Message-Id: <200808081450.m78Eo4RX068921@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Mateusz Guzik" Cc: Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mateusz Guzik List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Aug 2008 14:50:05 -0000 The following reply was made to PR kern/126368; it has been noted by GNATS. From: "Mateusz Guzik" To: bug-followup@freebsd.org Cc: Subject: Re: kern/126368: Running ktrace/kdump in jail leads to stale jails Date: Fri, 8 Aug 2008 16:47:49 +0200 ------=_Part_50034_12786102.1218206869075 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, the same problems exists in CURRENT. It seems that ktr_writerequest() calls crhold() on credentials, but doesn't free it when exiting. Attached patch (simple crfree() before return) fixes this problem (at least for me :>). Thanks, -- Mateusz Guzik ------=_Part_50034_12786102.1218206869075 Content-Type: application/octet-stream; name=kern_ktrace.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fjmwvn4l0 Content-Disposition: attachment; filename=kern_ktrace.diff LS0tIHN5cy9rZXJuL2tlcm5fa3RyYWNlLmMub3JpZwkyMDA4LTA4LTA4IDE2OjM3OjQ1LjAwMDAw MDAwMCArMDIwMAorKysgc3lzL2tlcm4va2Vybl9rdHJhY2UuYwkyMDA4LTA4LTA4IDE2OjM4OjIx LjAwMDAwMDAwMCArMDIwMApAQCAtOTMzLDEwICs5MzMsMTEgQEAKIAkJZXJyb3IgPSBWT1BfV1JJ VEUodnAsICZhdWlvLCBJT19VTklUIHwgSU9fQVBQRU5ELCBjcmVkKTsKIAlWT1BfVU5MT0NLKHZw LCAwLCB0ZCk7CiAJdm5fZmluaXNoZWRfd3JpdGUobXApOwogCXZyZWxlKHZwKTsKIAlWRlNfVU5M T0NLX0dJQU5UKHZmc2xvY2tlZCk7CisJY3JmcmVlKGNyZWQpOwogCWlmICghZXJyb3IpCiAJCXJl dHVybjsKIAkvKgogCSAqIElmIGVycm9yIGVuY291bnRlcmVkLCBnaXZlIHVwIHRyYWNpbmcgb24g dGhpcyB2bm9kZS4gIFdlIGRlZmVyCiAJICogYWxsIHRoZSB2cmVsZSgpJ3Mgb24gdGhlIHZub2Rl IHVudGlsIGFmdGVyIHdlIGFyZSBmaW5pc2hlZCB3YWxraW5nCg== ------=_Part_50034_12786102.1218206869075--