From owner-svn-src-all@FreeBSD.ORG Sun Sep 8 17:00:43 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27D3F3EA; Sun, 8 Sep 2013 17:00:43 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vb0-x231.google.com (mail-vb0-x231.google.com [IPv6:2607:f8b0:400c:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B79CC2705; Sun, 8 Sep 2013 17:00:42 +0000 (UTC) Received: by mail-vb0-f49.google.com with SMTP id w16so3290856vbb.36 for ; Sun, 08 Sep 2013 10:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Jy0Db+VXkG7x1/KfjPc4CtZgZsj5v0yxlWs7HyN/058=; b=Dz6PELnM7abbU1/YV3osUAFcYtPWDITf140sXrwE2hoLz79DvK9Q5NqsmVi7jklQbW 2DT01YcNCVuKSiyWYBssYVR8PXso2Toaksbtl30uLXsAjFmfuH1WKG9aVuRX8akycS1b BnFreRFuEnHtfcj5WwC3EazXRLHyeO0i0b1KEoYKMHpF+hQRaEJCKqITWyQjvsHmnDmt tukU5WFsN/jTSKhKD4R6Ry+4cm223PrMGVqZ6u4mvvmHVxtbJyGrVqln5U/suSY+iKxv HrlRvs8f3R1aaCT5wIuba1QItQdcIzHygavCDw+IdZ89sTTA7E5jElmPZiD0+QpxWETJ 3Udg== MIME-Version: 1.0 X-Received: by 10.52.173.165 with SMTP id bl5mr11497637vdc.18.1378659641916; Sun, 08 Sep 2013 10:00:41 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.65.132 with HTTP; Sun, 8 Sep 2013 10:00:41 -0700 (PDT) In-Reply-To: References: <201309071350.r87DoDUb005690@svn.freebsd.org> Date: Sun, 8 Sep 2013 19:00:41 +0200 X-Google-Sender-Auth: DvOCBEuAB9bAMsNUqefn33yoNL8 Message-ID: Subject: Re: svn commit: r255360 - head/sys/net From: Davide Italiano To: Ed Schouten Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 17:00:43 -0000 On Sun, Sep 8, 2013 at 6:26 PM, Ed Schouten wrote: > 2013/9/7 Davide Italiano : >> Log: >> Don't clear the unused SI_CHEAPCLONE flag in tap_create()/tuncreate(). > > Both the tun and the tap driver still use clonelists, right? I'm not > sure this fix is all right. > > -- > Ed Schouten Please correct me if I'm wrong, but from what I see r204464 (by kib@) removed the set of SI_CHEAPCLONE flag from both if_tap and if_tun so I think that's just a leftover. Also, SI_CHEAPCLONE implementation inside devfs is pretty unfinished, so even though we restore that piece of code inside the driver I'm not sure it will accomplish anything. Most of the drivers already removed the usage already. As a side note, I've already discussed with Kostik how to handle this in the future and he thinks (and I agree) that the right action there is to remove clones and SI_CHEAPCLONE, or implement the real SI_CHEAPCLONE semantic. I would strongly go for the first option, but if that won't be technically possible I think we should re-evaluate when/how to reintroduce the SI_CHEAPCLONE flag inside drivers. I hope this makes sense to you. Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare