Date: Sun, 28 Aug 2016 14:25:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kubilay Kocak <koobs@FreeBSD.org> Cc: Matthias Andree <mandree@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420966 - head/security/openvpn Message-ID: <20160828142557.GB71324@FreeBSD.org> In-Reply-To: <f11497cc-2ed7-12ee-60a7-24afe4b63633@FreeBSD.org> References: <201608270932.u7R9WUbC074827@repo.freebsd.org> <f11497cc-2ed7-12ee-60a7-24afe4b63633@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 27, 2016 at 07:58:08PM +1000, Kubilay Kocak wrote: > On 27/08/2016 7:32 PM, Matthias Andree wrote: > > New Revision: 420966 > > URL: https://svnweb.freebsd.org/changeset/ports/420966 > > > > Log: > > Make self-test the TEST option, support make test. Enabled by default. > > > NB: This is a critical port with many users, and the test is low on > > resources, it takes two minutes idling, waiting for timers to expire. > > I'm a HUGE proponent of additional tests/QA/quality in ports/packaging. > > However, users can run make test at any time to verify QA in their > environments. What is the actual rationale *for* running tests > post-build in all/any environments (including packaging) by default? Is > the aim to have packaging fail if it doesn't pass? > > Should all our 'critical' ports do the same thing? Should we instead > mark 'critical' ports in some manner and have the framework run these > tests-post-build by default? +1. We do have proper support for tests since CHANGES@20150928. Ideally, those TEST options should be gone, and on-demand tests/QA logic implemented in standard terms that are usable by package builders. Ports users do not need to opt-out of tests (by deselecting an OPTION or even patching port's Makefile); those who need it should just run `make test'. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160828142557.GB71324>