From owner-p4-projects@FreeBSD.ORG Fri Aug 3 20:59:18 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 882A716A418; Fri, 3 Aug 2007 20:59:18 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 472C416A41F; Fri, 3 Aug 2007 20:59:18 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id 10C3213C45B; Fri, 3 Aug 2007 20:59:18 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id E8F0C8BEEA2; Fri, 3 Aug 2007 22:59:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7aK-ITco+7gb; Fri, 3 Aug 2007 22:59:15 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 612748BEEA0; Fri, 3 Aug 2007 22:59:15 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l73KxF5P012592; Fri, 3 Aug 2007 22:59:15 +0200 (CEST) (envelope-from rdivacky) Date: Fri, 3 Aug 2007 22:59:14 +0200 From: Roman Divacky To: Jung-uk Kim Message-ID: <20070803205914.GA12533@freebsd.org> References: <200708021130.l72BUHrY077198@repoman.freebsd.org> <200708021714.33543.jkim@FreeBSD.org> <20070803081032.GA64605@freebsd.org> <200708031203.36406.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708031203.36406.jkim@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: perforce@FreeBSD.org Subject: Re: PERFORCE change 124529 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2007 20:59:18 -0000 > > cpumaskt_t is just an unsigned int so ~0 should be fine. > > For now. ;-) I was thinking about increasing it some time after 7.0 > branching. It is very clear that we will need it soon, i.e., > multicore CPUs are becoming more common these days. FreeBSD/sun4v > already hit the limit with just one processor: > > http://www.fsmware.com/sun4v/dmesg_latest.txt > > Even on amd64/i386 world, we will hit it very soon, e.g., octal-core * > quad-socket => 32 cores. Without increasing the sizeof(cpumask_t) > and/or grouping physical cores per socket, we won't be able to > survive very long. yeah yeah.. ;) maybe we can use the same trick linux did. anyway its ok now. > > in FreeBSD it doesnt make any sense to emulate linux size because > > if fbsd doesnt support that many CPUs we cannot emulate it. So > > using fbsd-sized cpumask_t and telling userland about it is ok. > > > > agree? > > Agreed, for 7.0. We should fix it later when we add something like > sched_{get,set}affinity() syscalls. http://people.freebsd.org/~ssouhlal/testing/setaffinity-20070707.diff I already asked attilio@ to review it and hopefully do something about it. > > thnx for the review! > > Thank you! so... do you agree that the current revision is fine. I need this to get kib@ to commit this... thank you roman