From owner-cvs-all@FreeBSD.ORG  Sun Nov 28 14:37:18 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2EB1716A4CE; Sun, 28 Nov 2004 14:37:18 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1F14643D39; Sun, 28 Nov 2004 14:37:18 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iASEbHlc013007;
	Sun, 28 Nov 2004 14:37:17 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iASEbHvP013006;
	Sun, 28 Nov 2004 14:37:17 GMT
	(envelope-from rwatson)
Message-Id: <200411281437.iASEbHvP013006@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 28 Nov 2004 14:37:17 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Nov 2004 14:37:18 -0000

rwatson     2004-11-28 14:37:17 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             kern_descrip.c 
  Log:
  Don't acquire Giant before calling closef() in close() (and elsewhere);
  instead acquire it conditionally in closef() if it is required for
  advisory locking.  This removes Giant from the close() path of sockets
  and pipes (and any other objects that don't acquire Giant in their
  fo_close path, such as kqueues).  Giant will still be acquired twice for
  vnodes -- once for advisory lock teardown, and a second time in the
  fo_close method.  Both Poul-Henning and I believe that the advisory lock
  teardown code can be moved into the vn_closefile path shortly.
  
  This trims a percent or two off the cost of most non-vnode close
  operations on SMP, but has a fairly minimal impact on UP where the cost
  of a single mutex operation is pretty low.
  
  Revision  Changes    Path
  1.258     +7 -7      src/sys/kern/kern_descrip.c