From owner-cvs-all@FreeBSD.ORG  Tue Jul  6 15:15:14 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EA35716A4CE; Tue,  6 Jul 2004 15:15:14 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DF67E43D1D; Tue,  6 Jul 2004 15:15:14 +0000 (GMT)
	(envelope-from des@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i66FFEcV028140;
	Tue, 6 Jul 2004 15:15:14 GMT
	(envelope-from des@repoman.freebsd.org)
Received: (from des@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i66FFEMx028139;
	Tue, 6 Jul 2004 15:15:14 GMT
	(envelope-from des)
Message-Id: <200407061515.i66FFEMx028139@repoman.freebsd.org>
From: Dag-Erling Smorgrav <des@FreeBSD.org>
Date: Tue, 6 Jul 2004 15:15:14 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/contrib/isc-dhcp/client dhclient.c
 src/contrib/isc-dhcp/common
 dispatch.c src/contrib/isc-dhcp/includes dhcpd.h
 src/contrib/isc-dhcp/omapip dispatch.c mrtrace.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jul 2004 15:15:15 -0000

des         2004-07-06 15:15:14 UTC

  FreeBSD src repository

  Modified files:
    contrib/isc-dhcp/client dhclient.c 
    contrib/isc-dhcp/common dispatch.c 
    contrib/isc-dhcp/includes dhcpd.h 
    contrib/isc-dhcp/omapip dispatch.c mrtrace.c 
  Log:
  Fix a number of incorrect assumptions regarding the size of time_t.
  The code has its own TIME type, which is actually defined to time_t,
  but it still used u_int32_t in some places.
  
  In addition, dhclient not only had two separate global cur_time
  variables, one of which was defined as u_int32_t and the other as
  TIME, but cur_time was sometimes shadowed by local variables, leading
  to widespread confusion as to which of these variable was being
  referenced.
  
  There is a lesson in here somewhere: a decent compiler with warnings
  enabled should have caught all of this long before it became a
  problem.
  
  This patch has been submitted to the vendor, but it will likely be
  some time before they release a version that includes it.
  
  Approved by:    mbr
  
  Revision  Changes    Path
  1.38      +1 -1      src/contrib/isc-dhcp/client/dhclient.c
  1.6       +1 -2      src/contrib/isc-dhcp/common/dispatch.c
  1.10      +2 -2      src/contrib/isc-dhcp/includes/dhcpd.h
  1.2       +22 -29    src/contrib/isc-dhcp/omapip/dispatch.c
  1.2       +22 -29    src/contrib/isc-dhcp/omapip/mrtrace.c