From owner-freebsd-testing@FreeBSD.ORG Fri Jun 13 00:53:48 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1954C71; Fri, 13 Jun 2014 00:53:48 +0000 (UTC) Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com [IPv6:2607:f8b0:4001:c03::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6368E2C9A; Fri, 13 Jun 2014 00:53:48 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id rl12so1848964iec.39 for ; Thu, 12 Jun 2014 17:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lRYFZ6toM12hksv1HWb8skXLgPNDXCySL7ui8yEHcM4=; b=eeXhenW6i66OD2quPWUBsx/rTymjtbECGf6GL5NLJXSkIYS0QN5LNRpscnVl+nSf7U v5r/RePf4GKx9BS30wJgv62D+yo2EwcjSs/MTGzxx4VVfxxRcLp6eTCMYWnx4/egyMSQ AiXyH9dw2av90D2EGxAtCbm0a97isGw4VWDLIenSJzcWHIjgdt0UMBC/bL1GihXCaMZp Dp8TooYiTrfcC2g6LT0ws1WAFJMrTCiq6ZiWG3Ud5Ma+qqgVMg9SI/ckx4bWh8ZOSu5F XqzjAmibwfDw/8VzhZlghMfeFnDESIDbyfM18uNHZbmcRwrkaIdchSVy2vkGjfbMwEJ4 mdCQ== MIME-Version: 1.0 X-Received: by 10.50.61.141 with SMTP id p13mr13955igr.38.1402620827771; Thu, 12 Jun 2014 17:53:47 -0700 (PDT) Received: by 10.50.28.198 with HTTP; Thu, 12 Jun 2014 17:53:47 -0700 (PDT) In-Reply-To: <20140511153203.GA81002@stack.nl> References: <20140124162759.GB90996@stack.nl> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> <20140511153203.GA81002@stack.nl> Date: Thu, 12 Jun 2014 17:53:47 -0700 Message-ID: Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF From: Garrett Cooper To: Jilles Tjoelker Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 00:53:48 -0000 On Sun, May 11, 2014 at 8:32 AM, Jilles Tjoelker wrote: ... > This is OK with me as long as important use cases for me are not broken: > > 1. Allow running new tests on a potentially broken new sh without > installing anything. This used to be possible using 'make regress' in > src/bin/sh/ but this was removed. I now use > SH=$PWD/obj/sh sh tests/legacy_test.sh > (I have an obj/ subdirectory to make the built objects more easily > accessible). > This should also work on stable/9 although it is acceptable to need a > few local hacks for that (as is already the case for MK_TESTS and > src.opts.mk). On head, it should work without local hacks. I allow you to change the shell via TEST_SH -- is that acceptable for the first drop (I'll look at revising the code to permit runtime overrides via kyua)? > 2. Allow installing using a read-only /usr/obj (mounted over NFS). This > means that everything needs to be built during buildworld. > Installworld should not build anything. > (I currently have local hacks: Kyuafile.auto is not built so I added > all: Kyuafile.auto > to some tests/Makefiles; I guess this should be in .) That's another issue entirely that you brought up in another thread. I'll see if that's still an issue.. Thank you! -Garrett