From owner-freebsd-ports@freebsd.org  Mon Aug 29 23:27:36 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 774E6BC721E
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Mon, 29 Aug 2016 23:27:36 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 58B8B80A;
 Mon, 29 Aug 2016 23:27:36 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u7TNRRxS015120;
 Mon, 29 Aug 2016 16:27:31 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201608292327.u7TNRRxS015120@gw.catspoiler.org>
Date: Mon, 29 Aug 2016 16:27:27 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: FreeBSD Port: ports-mgmt/poudriere
To: 000.fbsd@quip.cz
cc: bdrewery@FreeBSD.org, freebsd-ports@FreeBSD.org
In-Reply-To: <57C4B7F3.4040003@quip.cz>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2016 23:27:36 -0000

On 30 Aug, Miroslav Lachman wrote:
> Hi,
> 
> I would like to report one "dangerous" problem with "poudriere ports -d" 
> command. There should be a "-p treename" but if it is omitted, poudriere 
> deletes tree "default"
> 
> This is my error, I know, but I think poudrier should print a warning or 
> do not assume I wanted delete "default"
> 
> root@sm-reserve ~/# poudriere ports -d headtest
> [00:00:00] ====>> Deleting portstree "default" done
> 
> It should be
> 
> root@sm-reserve ~/# poudriere ports -d -p headtest
> [00:00:00] ====>> Deleting portstree "headtest" done

Yeah, that bit me too.  The poudriere man page even says:

     Except for -l, all of the subcommands require the -p switch (see
     below).

Even worse in my case, it deleted a ports tree that was not even created
by poudriere.  My default ports tree is actually /usr/ports and I hooked
it into poudrire by doing something like:
	poudriere ports -c -p default -F -M /usr/ports

IMHO, if the ports tree was not created by poudriere, then -k should be
the default when deleting it.