From owner-svn-src-all@freebsd.org Wed Jul 29 17:15:45 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 208AA9AE24A; Wed, 29 Jul 2015 17:15:45 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yk0-x22a.google.com (mail-yk0-x22a.google.com [IPv6:2607:f8b0:4002:c07::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CDD36325; Wed, 29 Jul 2015 17:15:44 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by ykay190 with SMTP id y190so13353479yka.3; Wed, 29 Jul 2015 10:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+nJBlHuwcyaeIxIVE440ivrs+PqYXCCfQJb5aHBYbLo=; b=L+yGVKJK/QUiUGkyFl0qkrvKaL0EVqZsQkRRPTYrk1/Zb8H3VVWf4JwsYqyAJRMs6q 8+mOjP2qvn9u/Sfz0TjqOWTC+vUAA+oouNYe+PXdtfyt6GtbrTPEzSVBA8zMJuuh5JCm ogxFcVcAXdLAk48LouSsGvSzhJBgyHdYsgMXNtgZx8463WBGcA0iQD5XsblcjlPl5Y9f MrCh+FmJ/VSpe+mDOYfuGovLWU8CXtdIo5lctRhZS8YgQq6A73z+BR9L1S9Tk5EY7Y8l MzLGH3YKQ8S1uOI4WFvPjn/Wil529Mi4Lpfd5LmhqrqDzMdhnHKH/DjbaJ0jVWnY10GL pamg== MIME-Version: 1.0 X-Received: by 10.170.198.144 with SMTP id p138mr45384882yke.70.1438190144071; Wed, 29 Jul 2015 10:15:44 -0700 (PDT) Sender: ermal.luci@gmail.com Received: by 10.129.83.139 with HTTP; Wed, 29 Jul 2015 10:15:44 -0700 (PDT) In-Reply-To: References: <201507021810.t62IAgCc003272@repo.freebsd.org> <20150728124220.GW72729@FreeBSD.org> <20150729150544.GM97401@FreeBSD.org> Date: Wed, 29 Jul 2015 19:15:44 +0200 X-Google-Sender-Auth: pNwg4G_KbBFpe6AJlpUAYyVMBl0 Message-ID: Subject: Re: svn commit: r285051 - head/sys/netinet From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: George Neville-Neil Cc: Gleb Smirnoff , =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 17:15:45 -0000 On Wed, Jul 29, 2015 at 6:48 PM, George Neville-Neil wrote: > > > On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote: > > Ermal, >> >> On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Lu=C3=A7i wrote: >> E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt) >> E> > E> */ >> E> > E> if (!srcrt && ia =3D=3D NULL) { >> E> > E> icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0, 0= ); >> E> > E> + RO_RTFREE(&ro); >> E> > E> return; >> E> > E> } >> E> > >> E> > Here the ifa reference is leaked upon return. >> E> > >> E> > >> E> Gleb, >> E> >> E> the improvement on the ifa_ref not needed is something to look at but >> the >> E> ifa_ref here is not lost since ia =3D=3D NULL, no? >> E> Maybe i am missing something else. >> >> Sure you are right. Mea culpa. >> >> E> Also can we put this on a review? >> >> It is possible. Let's just wait for Olivier to return and ask him to >> do a benchmark :) >> >> > Olivier isnt' the only one that can do a benchmark. I can chuck this up > in the > Sentex lab, that's what it's for. Give me a brief outline and I'll code > something > up in Conductor. > The outline is simple. Just forwarding performance in terms of PPS for normal forwarding with the patch suggested from Gleb builtin. pmcstat data would be useful as well during this bench :) > > Best, > George > --=20 Ermal