From nobody Wed Feb 18 00:08:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFxgv6TPVz6SKp7 for ; Wed, 18 Feb 2026 00:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFxgv3R1sz3DCh for ; Wed, 18 Feb 2026 00:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771373339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HDIvu5RLhR+kqHS9hYSWbzviubhYp2/0ezdNv8GTloo=; b=LkFc3w7DvdPcHskFdfaq4R+IUZaguzufFe6B+bCUaKlZZf6ZsU/6GCEOmvFXJ7xWsNVQsd DddYCpSIyOdztyMoVJqBKgHeZnBrABfKLN0/WkVLko4rWceciw2XpYRUL3OVHT3IXwgOzo +RuzlZY2PFodOCvLjZwhEampKGLapnwK0SxoNnYK7RSKAtuLgghMa1q2gnBZi2NpCBeGzp GM0wSM7fUeziMNFZp9n++LymV04T3zuLpcUksikjud0ZtTGWaVsn4IG4+mZczmTX2zTHfB pIdOD2AZEzTxKa34SkxzaukK0tsJd2/gZmmkNSoawQuBEn+7xSwS4qBhxKwf6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771373339; a=rsa-sha256; cv=none; b=Q4ZCr0ar6bGyx+gh2aYBeVO2xIX50BP5mhhFPR4tPmedjilqlNnyCneIdhsaJgiWXF9P86 7xVN3sq+pdEjvXiWB6VNMZGGBOkoOhBvAhqQnRcYm9xSQ6WK6oZ0epL1uh8v/SgxRmXcOE L8OMvKJWxdhoqiqG0TFR4GlnVFvzX7b2pa1U48Mb3HtYQd5695A9leXrQjCrCo1svjCloh 71Wjl8Tf2U3a3AWhGlQmXxml5q0EvG4vfUmpo5LpULbOEbePLzP+wvHUota+jiNFpVruEd S2cquwXVjU4Bq4lZuItdvrwv53QVoBBm/M6mSdKO9WTy6zQ+y8ME3UKF1vuO2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771373339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HDIvu5RLhR+kqHS9hYSWbzviubhYp2/0ezdNv8GTloo=; b=N3R4nesmXCAnGMAzjFo81KUjAKLPOqI5r7ZHgFYARii0luTb2vQ2H98/7sqXGuwzhKSDpv b5LyjhjOO8fo+sFjVN9VcPxzIEQpql46FyiQWZEx05A6mHFJCZOj3m8f/BCGCX8QqZfcT1 SPDxfZW0iAovnYfd4sNVaCB6MutzcE7rOpBJT4Q1vY9172Cd5vnNhQgElSVDPz0cPN8FHF ZMW4ohmQoGPy/OKLsqXi/dEtH+DEWZAX/ml2SsDwRvhQOYO2GnC6I7ffvGG8EV/eMUSX30 PacpPRw1NnKGCr8kqsBJR9uB0mQ7u123df+QaPJfO99VCmRH5ao7vAakLCmCWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fFxgv2FtPzXhd for ; Wed, 18 Feb 2026 00:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c4a4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 18 Feb 2026 00:08:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 71c0f48ab19f - stable/14 - ngctl: Check hook name length List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 71c0f48ab19fbac3d93e29d8964db2f215ddf722 Auto-Submitted: auto-generated Date: Wed, 18 Feb 2026 00:08:59 +0000 Message-Id: <6995031b.3c4a4.69963026@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=71c0f48ab19fbac3d93e29d8964db2f215ddf722 commit 71c0f48ab19fbac3d93e29d8964db2f215ddf722 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-13 15:57:46 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-17 23:12:02 +0000 ngctl: Check hook name length Check the length of the hook name when copying it into the sockaddr. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55258 (cherry picked from commit 585190dff436eeea3be97300e36c82559028d3dd) --- usr.sbin/ngctl/write.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/usr.sbin/ngctl/write.c b/usr.sbin/ngctl/write.c index 1e86963fb39c..7ee8dcfaa241 100644 --- a/usr.sbin/ngctl/write.c +++ b/usr.sbin/ngctl/write.c @@ -35,10 +35,12 @@ #include #include +#include #include #include #include +#include #include #include "ngctl.h" @@ -63,6 +65,7 @@ WriteCmd(int ac, char **av) struct sockaddr_ng *sag = (struct sockaddr_ng *)sagbuf; u_char buf[BUF_SIZE]; const char *hook; + size_t hooklen; FILE *fp; u_int len; int byte; @@ -72,6 +75,14 @@ WriteCmd(int ac, char **av) if (ac < 3) return (CMDRTN_USAGE); hook = av[1]; + _Static_assert(sizeof(sagbuf) >= + offsetof(struct sockaddr_ng, sg_data) + NG_HOOKSIZ, + "sagbuf is too small for NG_HOOKSIZ"); + hooklen = strlcpy(sag->sg_data, hook, NG_HOOKSIZ); + if (hooklen >= NG_HOOKSIZ) { + warnx("hook name \"%s\" too long", hook); + return (CMDRTN_ERROR); + } /* Get data */ if (strcmp(av[2], "-f") == 0) { @@ -104,11 +115,10 @@ WriteCmd(int ac, char **av) } /* Send data */ - sag->sg_len = 3 + strlen(hook); + sag->sg_len = 3 + hooklen; sag->sg_family = AF_NETGRAPH; - strlcpy(sag->sg_data, hook, sizeof(sagbuf) - 2); - if (sendto(dsock, buf, len, - 0, (struct sockaddr *)sag, sag->sg_len) == -1) { + if (sendto(dsock, buf, len, 0, (struct sockaddr *)sag, + sag->sg_len) < 0) { warn("writing to hook \"%s\"", hook); return (CMDRTN_ERROR); }