From owner-freebsd-bugs@FreeBSD.ORG Tue Jan 28 06:40:01 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B237C38 for ; Tue, 28 Jan 2014 06:40:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 667C51D37 for ; Tue, 28 Jan 2014 06:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0S6e1GN095327 for ; Tue, 28 Jan 2014 06:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0S6e1JO095326; Tue, 28 Jan 2014 06:40:01 GMT (envelope-from gnats) Date: Tue, 28 Jan 2014 06:40:01 GMT Message-Id: <201401280640.s0S6e1JO095326@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: John Howie Subject: Re: misc/186006: buildworld libc build error "'MALLOC_PRODUCTION' macro redefined [-Werror]" in 10.0-RELEASE in jemalloc_jemalloc.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: John Howie List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2014 06:40:01 -0000 The following reply was made to PR misc/186006; it has been noted by GNATS. From: John Howie To: "bug-followup@FreeBSD.org" , John Howie Cc: Subject: Re: misc/186006: buildworld libc build error "'MALLOC_PRODUCTION' macro redefined [-Werror]" in 10.0-RELEASE in jemalloc_jemalloc.c Date: Tue, 28 Jan 2014 06:36:16 +0000 Did some digging and found the problem. The build script for ARM has the following line: make -C $SRCROOT MALLOC_PRODUCTION=3Dyes buildworld In the file contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h the following lines exist: #define MALLOC_PRODUCTION #ifndef MALLOC_PRODUCTION #define JEMALLOC_DEBUG #endif The bug is therefor not limited to the ARM processor build of 10.0-RELEASE. Recommendation is to remove the definition of MALLOC_PRODUCTION from the header file, and document MALLOC_PRODUCTION properly (it is referenced in https://wiki.freebsd.org/DefaultDebuggingKnobs and a few other places). Regards, John