From owner-svn-src-all@freebsd.org Thu Oct 1 19:51:23 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C279A0D23F; Thu, 1 Oct 2015 19:51:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5AC601768; Thu, 1 Oct 2015 19:51:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DC3E7B918; Thu, 1 Oct 2015 15:51:21 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288454 - head/usr.bin/truss Date: Thu, 01 Oct 2015 11:22:48 -0700 Message-ID: <5360523.S6ag5ugNqo@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201510011728.t91HS7fo006633@repo.freebsd.org> References: <201510011728.t91HS7fo006633@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 01 Oct 2015 15:51:22 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2015 19:51:23 -0000 On Thursday, October 01, 2015 05:28:07 PM John Baldwin wrote: > Author: jhb > Date: Thu Oct 1 17:28:07 2015 > New Revision: 288454 > URL: https://svnweb.freebsd.org/changeset/base/288454 > > Log: > - Remove extra integer argument from truncate() and ftruncate(). This is > probably fallout from the removal of the extra padding argument before > off_t in 7. However, that padding still exists for 32-bit powerpc, so > use QUAD_ALIGN. > - Fix QUAD_ALIGN to be zero for powerpc64. It should only be set to 1 > for 32-bit platforms that add padding to align 64-bit arguments. I'm not sure how the situation is on arm and MIPS, but on powerpc, both the 32-bit and 64-bit platforms define __powerpc__ (unlike amd64 which doesn't define __i386__ for example) making proper #ifdef's for just 32-bit __powerpc__ a bit of a PITA. -- John Baldwin