From owner-svn-src-stable@freebsd.org Thu Mar 15 17:07:17 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2133BF61B9D for ; Thu, 15 Mar 2018 17:07:17 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB8806BC98 for ; Thu, 15 Mar 2018 17:07:16 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yw0-x234.google.com with SMTP id v68so2518608ywg.13 for ; Thu, 15 Mar 2018 10:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l7fxNEd3HOQFnX5HCyI8s04AFz9z2LOsq8OoyAZK3zo=; b=W/wbAJxYpsHo0ANYRTEVOGMiSDZ1ivjaJHhAgEMxRW6C7luHdsvtp7jxWxiKPdP8sh K/XUsCrouxpNfXleFXvxl/BmHjdqKtbvMUJIkSHvNxPkkT/QKuarR5Xy6Ab/sHBeM13g Z+usECEuLmQAEvO8U9WhezQ/mOP1JSzdNCYCEk8aX6DhG7AskGViEvsicauivkKtF9oO hpBDsikXAuMi8KzeXxr8GIaAA2JabepHmrgnkSzfY5/diV2xS8bSHSN6NpmP1vQWokxC TOaeYpP8Q0HVDPjWAzRY4lP5KJrkkwamWtmk4qnJdjrInlfDBn71GE+l4jtV5bLSHbZn eOaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l7fxNEd3HOQFnX5HCyI8s04AFz9z2LOsq8OoyAZK3zo=; b=DFUak9+HmKDmbx1kI77zEiU3W2sKAwOWq1YuOltKmoyW/HoWsI++7afkxeY1+TTiUg noJYAw1SkLLsNexeq4JalfvdTtSnVqqpzemoQEcRFZasX7O1KmK/kx/WFW2bMRN6h8o5 GcQKStV1dIqPjVLDcPqRh6zlpDhqd/HHQRSgZzfL/yoklzmGldUIbrDD+m1ioYG+IjVr ONc2aGdes7gcAIv4DtbAkVZ/+1S3iccapZRDw+saHMLqodVoTjgLGLKn74MGE6VfvFDg 8qojJ6EFPt6jQUdikuaID9k3CL1UlItUE+ZAB5tj5WRoNJZ9z12B+JZXi5ElXEGVXjke tyIQ== X-Gm-Message-State: AElRT7FSiFe855ibTdH8o6Jl3GrP2Ia751rV3d3sfC07+udhf/bzdp9o 9kTyxKYboqdTDsEwC46paP/PWQ274ngHLggyVVJOyw== X-Google-Smtp-Source: AG47ELtpNx/O2x1Tu+U4gqw356LLeeO51rRt2KJYPZDhbD9rkdqvYIJWEpxwl3R2caY/h8b6k5FnKMfeurnmC3aC0v4= X-Received: by 2002:a25:5047:: with SMTP id e68-v6mr6284286ybb.165.1521133636160; Thu, 15 Mar 2018 10:07:16 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:3492:0:0:0:0:0 with HTTP; Thu, 15 Mar 2018 10:07:15 -0700 (PDT) In-Reply-To: References: <201803151614.w2FGEttu093805@pdx.rh.CN85.dnsmgr.net> <1521130827.99081.43.camel@freebsd.org> From: Oliver Pinter Date: Thu, 15 Mar 2018 18:07:15 +0100 Message-ID: Subject: Re: svn commit: r330972 - stable/11/share/misc To: Warner Losh Cc: Ian Lepore , src-committers , Eitan Adler , Justin Hibbits , "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable-11@freebsd.org" , Andriy Gapon , "Rodney W. Grimes" X-Mailman-Approved-At: Thu, 15 Mar 2018 17:25:33 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 17:07:17 -0000 On Thursday, March 15, 2018, Warner Losh wrote: > On Thu, Mar 15, 2018 at 10:31 AM, Warner Losh wrote: > > > > > > > On Thu, Mar 15, 2018 at 10:20 AM, Ian Lepore wrote: > > > >> On Thu, 2018-03-15 at 09:14 -0700, Rodney W. Grimes wrote: > >> > > > >> > > On Thu, 2018-03-15 at 10:52 -0500, Justin Hibbits wrote: > >> > > > > >> > > > On Thu, Mar 15, 2018 at 10:46 AM, Ian Lepore > >> > > > wrote: > >> > > > > > >> > > > > > >> > > > > I agree completely with all of this.??It bothers me how many > >> > > > > committers > >> > > > > have the attitude that handling MFCs is not part of being a > >> > > > > committer. > >> > > > Never attribute to arrogance that which can adequately be > >> > > > explained > >> > > > by > >> > > > sheer laziness ;) > >> > > > > >> > > > - Justin (guilty of marking changes as MFC after, and ignoring > >> > > > them > >> > > > for far too long) > >> > > > > >> > > Laziness and procrastination I understand -- I own a lovely glass > >> > > house > >> > > in that neighborhood. ?I tend to put off MFCs for way too long then > >> > > every few months have to spend a whole weekend catching up. > >> > MFC: 1 week (by pool|self) #defaults to self if missing > >> > > >> > There is already a very nice tracking tool for outstanding MFC's, > >> > if we added a bit of smarts in its parser, and created a pool of > >> > MFC commiters (Eitan seems to have started one :-)) those who > >> > do not want to do there own MFC work could pass the hat. > >> > >> If you're talking about the MFC after: field in commits, I don't use > >> it. I have about zero tolerance for being nagged by anybody about > >> anything, and that goes double for robots nagging me with spam mail. > >> > >> The MFC tool that works well for me is gonzo's MFCTracker site [*] that > >> doesn't require extra markup in the commit messages. > >> > > > > I also have a MFC tool for git, but it's n > > > > [[ stupid track pad and too easy button pushes... ]] > > but it's not ready for prime time. It's useful if you have a list of things > you want to MFC for playing them onto the stable branch so you can test > before committing to svn stable. It shows the big issues with moving to git > as the source of truth, though. We have way too much traffic in the repo to > have git cherry to produce any kind of reasonable output (too many changes, > can't restrict to a subset of the tree, no way to check prior commits to > files affected, etc), and the git cherry-pick command relies a bit too much > on the merge magic, so it doesn't record merges (there is no merge-info in > git). > > However, I could dust off the tool and fix up the rough edges if there's > any interest at all. Kyle Evans used it to MFC my crazy src/stand stuff... > > I use this script to merge / cherry-pick changes from master: https://github.com/opntr/opBSD-ng-tools/blob/master/git/opBSD_mfc.sh > Warner > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to " > svn-src-stable-11-unsubscribe@freebsd.org" >