From owner-svn-ports-all@freebsd.org Sun Jun 30 08:49:53 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B0E215D03A4; Sun, 30 Jun 2019 08:49:53 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3B64769B0; Sun, 30 Jun 2019 08:49:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id DFF864092; Sun, 30 Jun 2019 08:49:52 +0000 (UTC) Date: Sun, 30 Jun 2019 08:49:52 +0000 From: Alexey Dokuchaev To: Thomas Zander Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505349 - in head/multimedia: mencoder mplayer mplayer/files Message-ID: <20190630084952.GA59213@FreeBSD.org> References: <201906291312.x5TDCkK1030164@repo.freebsd.org> <20190629150321.GA97932@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: F3B64769B0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.88)[-0.881,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2019 08:49:53 -0000 On Sat, Jun 29, 2019 at 10:50:41PM +0200, Thomas Zander wrote: > On Sat, 29 Jun 2019 at 17:03, Alexey Dokuchaev wrote: > > The fact that you've dropped the RTC option is obvious from the commit > > diff itself. What's not obvious (and thus should be part of the commit > > log) is the reasons behind this decision. > > The advantages of supporting it have always been somewhat > questionable. Personally, I have never encountered a single issue that > could be solved by enabling RTC. > Also most of our video-playing user base have not been able to use it > for quite some time anyway, with nobody complaining: > > grep BROKEN /usr/ports/emulators/rtc/Makefile > BROKEN_FreeBSD_12= fails to compile: rtc.c:166:2: implicit > declaration of function 'MALLOC' is invalid in C99 > BROKEN_FreeBSD_13= fails to compile: rtc.c:166:2: implicit > declaration of function 'MALLOC' is invalid in C99 Thanks, I did not doubt that it was dropped for a reason. However, it should have been properly reflected (explained) in the commit log. ./danfe