From owner-freebsd-current@FreeBSD.ORG Tue Mar 16 00:29:48 2010 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DF31106566B for ; Tue, 16 Mar 2010 00:29:48 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id C6DB58FC19 for ; Tue, 16 Mar 2010 00:29:47 +0000 (UTC) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id o2G0Te9e037174; Mon, 15 Mar 2010 17:29:40 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.4/8.14.4/Submit) id o2G0Tdx5037173; Mon, 15 Mar 2010 17:29:39 -0700 (PDT) (envelope-from obrien) Date: Mon, 15 Mar 2010 17:29:39 -0700 From: "David O'Brien" To: "M. Warner Losh" Message-ID: <20100316002939.GA36963@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, "M. Warner Losh" , freebsd-current@FreeBSD.org References: <20100312171206.GA31761@dragon.NUXI.org> <20100313.211303.585238797224891349.imp@bsdimp.com> <20100315142806.GA5786@dragon.NUXI.org> <20100315.084426.824931270219314740.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100315.084426.824931270219314740.imp@bsdimp.com> X-Operating-System: FreeBSD 9.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current@FreeBSD.org Subject: Re: [PATCH] newvers.sh X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2010 00:29:48 -0000 On Mon, Mar 15, 2010 at 08:44:26AM -0600, M. Warner Losh wrote: > In message: <20100315142806.GA5786@dragon.NUXI.org> > "David O'Brien" writes: > : On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: > : > In message: <20100312171206.GA31761@dragon.NUXI.org> > : > "David O'Brien" writes: > : > : * Simplify SRCDIR calculation by directly finding the kernel sources > : > : based directly on one of them. > : > : Reviewed by: dhw > : > : This change does not increase the kernel build time. It also continues > : > : to restrict the revision to just the kernel sources, and not the whole > : > : tree. > : > : Timing tests by: dhw > : > > : > > : > > : > I have a better simplification, I think, that works for me for each of > : > the tests that I've done (both traditional and buildkernel builds). > : > : I also have other simplifications. But want to do this in stages, > : least there be some corner case or misunderstanding by someone. > > Normally this is a sensible process. However, my patches change how > we guess where sys is, and as such, I think we should go directly > there and work out the corner cases and such there. Well that's what I was trying to do with the patch I sent you in Message-ID: <20100308010125.GA6387@dragon.NUXI.org> on 7-March-2010. There you didn't care for that approach and would not give details as to the claims you made. I will reply in another email the issues with your patch. > : I would prefer to do this in stages so things aren't misunderstood. > : This patch is one of the key parts that shows I am not making the > : 'svnversion' run take longer, and that it does not cover more of > : the tree than before. > > That's exactly what my patch does by passing in SYSDIR directly. Why > guess and then replace it with a different guess. Guess??? 'newvers.sh' is not going to be within the kernel sources tree?? Are you allowing for the person that did a 'mv sys/conf/newvers.sh' to elsewhere? Considering you have "sh $S/conf/newvers.sh", I don't see where you are. Is "$0" confusing you? -- -- David (obrien@FreeBSD.org)