From owner-freebsd-bugs@FreeBSD.ORG Thu Nov 6 22:50:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D24F41065670 for ; Thu, 6 Nov 2008 22:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C170C8FC12 for ; Thu, 6 Nov 2008 22:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mA6Mo4cA084353 for ; Thu, 6 Nov 2008 22:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mA6Mo4It084352; Thu, 6 Nov 2008 22:50:04 GMT (envelope-from gnats) Date: Thu, 6 Nov 2008 22:50:04 GMT Message-Id: <200811062250.mA6Mo4It084352@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Sam Leffler Cc: Subject: Re: bin/128582: [patch] activate readline(3) support in wpa_cli X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sam Leffler List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2008 22:50:04 -0000 The following reply was made to PR bin/128582; it has been noted by GNATS. From: Sam Leffler To: Eygene Ryabinkin Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/128582: [patch] activate readline(3) support in wpa_cli Date: Thu, 06 Nov 2008 14:45:09 -0800 Eygene Ryabinkin wrote: > Sam, good day. > > Tue, Nov 04, 2008 at 11:37:22AM -0800, Sam Leffler wrote: >> readline support in wpa_cli is not enabled by default because it bloats >> the system with very little gain. It is trivial to have a local >> configuration that adds it w/o touching the source code but once added >> in the way proposed it is not possible to disable it w/o modification. > > OK, no problems: what about the attached patch? > >> I believe the original PR was submitted by brix@. I recently asked him >> to review it and decide whether he wanted to commit the change; >> otherwise close the PR. > > Yes, it is bin/116606. I had spotted from that patch that ncurses is > needed too and had explicitely added it to my patch. The main > difference between my and Henrik patches is that I am defining > additional knob WPA_CLI_WITH_READLINE that enables the realine support > (but only when MK_GNU_SUPPORT is defined too). So, by-default the > support won't be included and people will be able to turn it on > without resorting the the make trickery. And I had also described > this in the manual page. > > As a bonus, I had written proper support for the history command > validation for the potentially sensitive commands that shouldn't be > written to the disk. The original version was faulty and incomplete. > The patch is attached too. May be it should go upstream, I'll try to > submit it there too. > So long as it can be disabled I'm fine with adding the support. Thanks for following through on this. Yes, please do send your wpa_cli changes to Jouni (might want to check if they are already in later versions of the code). Sam