From nobody Wed Sep 7 17:35:33 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MN8Y434RRz4bjQs; Wed, 7 Sep 2022 17:35:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MN8Y42W4mz46HP; Wed, 7 Sep 2022 17:35:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662572136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6UEvGmejghwh/MvZUi3A9Te4Ts5XuWqsUV9oxwsPqI=; b=RASXoCamCyHgPern90QHgZ8NNCbtWHC6d2sO76J9wQ6FRbTjS1j/s9qYbOPBqQk7uAEHZz /9dPujONgghWaM1HcmTkX5qHExssW9mwD8RhaThp/Ixd9jRKqgVPKDGtePz6Mmv04MjkD4 ILOf4t1+tlLUmEysiEf2JM6XOzAPQMIbAe1x3J77HeUboLl0Hn9ZvykPnJRE3hEpoaQ4pk edcyEoDCrxgmdU8fxwnUYWq7jbvSSGPQlWJnYn6H7OS9US4Hqf4+C4tty+jierdxpxxRXs vfyEzYsXobgxukBF9txBZ7nWP/XZnasJZLKkaOn9OKu0YiqFiFOytl7B7/UkRg== Received: from [10.248.121.120] (global-5-144.n-2.net.cam.ac.uk [131.111.5.144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MN8Y352Sfz14xV; Wed, 7 Sep 2022 17:35:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <8df69740-5d20-5b3a-136d-ee8362a1173c@FreeBSD.org> Date: Wed, 7 Sep 2022 18:35:33 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: git: 94466c432ed6 - main - Revert "usb: Remove a double words in a source code comments" Content-Language: en-US To: Alexey Dokuchaev , Gordon Bergling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202209051346.285Dk4BC013542@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662572136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O6UEvGmejghwh/MvZUi3A9Te4Ts5XuWqsUV9oxwsPqI=; b=rh5UGJ36ARcQmcgrVv0w/Z+kSJ1FkxwyXyONsrg6hBks9S4ttbxZHYWMk/4waa1RiIQ19H OWCa3KygMFDlmDZqarwxpyFeUMoh/b2vlPcAFo9a7eAv0WkIXApPSNVNBcfN18vJFWVzis BOTU/V2TUDTidSTM+0Qk91iBE2BLahpCkwtxS/kd5TdXLTLV9wxskDctUW3vxd6cKnKMfQ 6kuj1S3e1KtfcruoivsXG2nzj9J1QFuFeEbhuynY2mpcIhO3l1JhKH+8ducIz6leADBbdu Dijz9VMhNA3QV9j5M2MZIxsqDUpNeTJsVTYEVkw0ZWqSwKY7PY+se1jx+AoNwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662572136; a=rsa-sha256; cv=none; b=TWVvPvfiUfTwLDUU7VWvMYuGGSS8JR3Kf54r+QO4IA+IyPNa+kVU0PGLkDaAhKDj2x0tzQ HbDFY4NBUCVC9NAWqZrMbmw7oOWYY/qGnJ2HhwXTumvuH9GZhK2oGUP+G/vURPJKC+bfuL S8I6hLa+HSviSKBg5rUEOIRUuZ6T8tPXx+/QXv3As6icLtg+sRJbmQFqH6fUpCV3JHaGcc uqqzLl3P2pMyMJzGUujwNF89c406iHhfi0u0s0T/6orgYAgDLSYWNJwPkSEmDdxmldvK/q kjdPmNBUTcYk27v9X/awQuv+c2PpA8rz/zbzs6zqPXLzjsg/yOE8fxjmUtDFXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/5/22 4:57 PM, Alexey Dokuchaev wrote: > On Mon, Sep 05, 2022 at 01:46:04PM +0000, Gordon Bergling wrote: >> commit 94466c432ed611a49cacae7ff99b224b37c906bb >> >> Revert "usb: Remove a double words in a source code comments" >> >> This reverts commit 8ca67bf1273a5168f8a3787183159c477632e582. >> >> The original comment was correct; changing it loses a key part. >> >> Reported by: jrtc27 > > jrtc27@ had pointed out two places, but you've reverted all three. > >> - * different from the muge_init() function in that one is designed to >> + * different from the muge_init() function in that that one is designed to > > Admittedly, I'd rather see the whole comment rephrased: these double thats > make it hard to read and just begging for someone, perhaps even you, "fix" > it again in the future. :) Agreed, maybe something like * different from the muge_init() function which is designed to -- John Baldwin