Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Sep 2022 18:35:33 +0100
From:      John Baldwin <jhb@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>, Gordon Bergling <gbe@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 94466c432ed6 - main - Revert "usb: Remove a double words in a source code comments"
Message-ID:  <8df69740-5d20-5b3a-136d-ee8362a1173c@FreeBSD.org>
In-Reply-To: <YxYcUxdLE6zxbbL8@FreeBSD.org>
References:  <202209051346.285Dk4BC013542@gitrepo.freebsd.org> <YxYcUxdLE6zxbbL8@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9/5/22 4:57 PM, Alexey Dokuchaev wrote:
> On Mon, Sep 05, 2022 at 01:46:04PM +0000, Gordon Bergling wrote:
>> commit 94466c432ed611a49cacae7ff99b224b37c906bb
>>
>>    Revert "usb: Remove a double words in a source code comments"
>>      
>>    This reverts commit 8ca67bf1273a5168f8a3787183159c477632e582.
>>      
>>    The original comment was correct; changing it loses a key part.
>>      
>>    Reported by:    jrtc27
> 
> jrtc27@ had pointed out two places, but you've reverted all three.
> 
>> - *	different from the muge_init() function in that one is designed to
>> + *	different from the muge_init() function in that that one is designed to
> 
> Admittedly, I'd rather see the whole comment rephrased: these double thats
> make it hard to read and just begging for someone, perhaps even you, "fix"
> it again in the future. :)

Agreed, maybe something like

* different from the muge_init() function which is designed to

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8df69740-5d20-5b3a-136d-ee8362a1173c>