Date: Sat, 14 Jan 2012 16:16:16 +0100 From: Rainer Hurling <rhurlin@gwdg.de> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-current <freebsd-current@FreeBSD.org> Subject: Re: HEADS UP: set_rcvar() removed from rc.subr Message-ID: <4F119C40.2080503@gwdg.de> In-Reply-To: <4F114577.30201@FreeBSD.org> References: <4F114577.30201@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14.01.2012 10:05 (UTC+1), Doug Barton wrote:
> Howdy,
>
> Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr.
> The concept of set_rcvar() was nice in theory, but the forks it creates
> are a drag on the startup process, which is especially noticeable on
> slower systems, such as embedded ones.
>
> I have no plans to MFC this change, so it should only affect users who
> are actually on 10-current. If you have scripts in /usr/local/etc/rc.d
> (which if you have ports installed you almost certainly do) ...
>
> to make the change by hand, change this:
>
> name=foo
> rcvar=`set_rcvar`
>
> to:
>
> name=foo
> rcvar=foo_enable
>
> I didn't bump PORTREVISIONs because the change only applies to HEAD. But
> all of the ports are updated, so if you can't figure out how to make the
> change, just reinstall it.
>
>
> Doug
Seems that ports-mgmt/tinderbox needs an update like this:
files/patch-etc__rc.d__tinderd
--- etc/rc.d/tinderd.orig 2011-11-20 07:01:09.000000000 +0100
+++ etc/rc.d/tinderd 2012-01-14 16:07:38.000000000 +0100
@@ -16,7 +16,7 @@
. /etc/rc.subr
name="tinderd"
-rcvar=`set_rcvar`
+rcvar=tinderd_enable
# read settings, set default values
load_rc_config "${name}"
Have not checked tinderbox-devel.
BTW, is there any reason not to set 'rcvar=${name}_enable' in all that
cases?
Rainer Hurling
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F119C40.2080503>