From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 26 17:30:02 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A9201065674 for ; Sun, 26 Aug 2012 17:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 425A18FC16 for ; Sun, 26 Aug 2012 17:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7QHU2km037198 for ; Sun, 26 Aug 2012 17:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7QHU2jK037190; Sun, 26 Aug 2012 17:30:02 GMT (envelope-from gnats) Resent-Date: Sun, 26 Aug 2012 17:30:02 GMT Resent-Message-Id: <201208261730.q7QHU2jK037190@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Raphael Kubo da Costa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 880D41065673 for ; Sun, 26 Aug 2012 17:20:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 70F628FC1C for ; Sun, 26 Aug 2012 17:20:06 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7QHK68G038239 for ; Sun, 26 Aug 2012 17:20:06 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7QHK6gw038238; Sun, 26 Aug 2012 17:20:06 GMT (envelope-from nobody) Message-Id: <201208261720.q7QHK6gw038238@red.freebsd.org> Date: Sun, 26 Aug 2012 17:20:06 GMT From: Raphael Kubo da Costa To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/171083: bsd.port.mk: Be more clear in the sanity-config error prompt X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2012 17:30:02 -0000 >Number: 171083 >Category: ports >Synopsis: bsd.port.mk: Be more clear in the sanity-config error prompt >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Aug 26 17:30:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Raphael Kubo da Costa >Release: 9-STABLE >Organization: FreeBSD >Environment: FreeBSD gibbon 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #54: Sat Aug 4 23:50:23 BRT 2012 root@gibbon:/usr/obj/usr/src/sys/GIBBON amd64 >Description: When one runs `make config' on a port and produces an invalid configuration, the current prompt says "Config is invalid. Re-edit? [Y/N]". It is not clear whether the default is thus 'Y' or 'N'. The attached patch makes it clear that 'Y' is the default. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: bsd.port.mk =================================================================== --- bsd.port.mk (revision 303176) +++ bsd.port.mk (working copy) @@ -6017,7 +6017,7 @@ .if !target(sanity-config) sanity-config: _check-config .if !empty(_CHECK_CONFIG_ERROR) - @echo -n "Config is invalid. Re-edit? [Y/N] "; \ + @echo -n "Config is invalid. Re-edit? [Y/n] "; \ read answer; \ case $$answer in \ [Nn]|[Nn][Oo]) \ >Release-Note: >Audit-Trail: >Unformatted: