From owner-svn-src-head@freebsd.org Thu Nov 22 07:16:36 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11F4E113D29C; Thu, 22 Nov 2018 07:16:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 586998F2CF; Thu, 22 Nov 2018 07:16:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd42.google.com with SMTP id r200so5908311iod.11; Wed, 21 Nov 2018 23:16:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JOby5YdW3aP5kBtyUEJ40PPwMljdEKUxIyUT/tSvqkU=; b=ssGpy9/jc1T3HNppj+UO9wTjxJXxzx92aOfQd8b8qgE/JX6sCeoB5wiu9JQrEIslye aVkasC5JjjXkhm45C2iYtdY686DnKmiKtlAmb1F4PRMjxVpIQuY861fOAaFmZSWWLSbY yyVyUh/ImWzJYWfIc7C0YCgXeJznc1cNYVZkCUZuV0NrulDSPXEKxgmOf+owkzovVF5x +eIWmIPqN5TliXQEJ0F9LVDTYXq4/SrjVRv/i1nS/iB5mQN7Zl9KLeVUftPNDLVZzRtH X4nVO4US+gy1cz5NklTA5h4kpMsE9hFlm4A58kbQmAduZlqiOV/+aNTYj6ebGPwdZhVP YJOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=JOby5YdW3aP5kBtyUEJ40PPwMljdEKUxIyUT/tSvqkU=; b=I7qv/m3CbYNaensuai9FwBKn1EaNNVVMuxgaj0PLuoqteN5z532xmjCtu3jxqPfT1v attBnCXMqGisDzToPT42dCmtavkyHhR+n8AqzOIpZjT11rrcGVlKbrIHasSBDBJoUVok BeKeciP6gR+Kk3Pu6hE/MFgmhcVnzK55lvXlXUNzIdAirUg5+ukfLcVwF1KhgK80JRsf CK3nbnnAYa5v7hfxtRwTrx143tbg2vzdWvc9Eiw7EZeis2ArcWWWFdHzf/p0lhMYhw8t UFiQIEsOGgmETvJCEnZSC1zpdpyHdFp2PJaSEHBjgthIbvxykF63EobusmpeoomEIiUt Ofgg== X-Gm-Message-State: AA+aEWaSyFVVpmXlAF7naYi663Jkqj8/pzsuVFETjHxeK9k+cEBIuWBJ OkLUJtdE0z+SlAJZ/8UvWwTt7dowsTc= X-Google-Smtp-Source: AFSGD/XPCkmiXAg/3T/YVPKkjc7KTk3LIs06xpGjxnmzxTc6fO4gUWvp/mxOfbr1Mle9RgR9hWE0jA== X-Received: by 2002:a6b:3fd7:: with SMTP id m206mr7129531ioa.210.1542870994434; Wed, 21 Nov 2018 23:16:34 -0800 (PST) Received: from raichu (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id e80-v6sm1567315itc.35.2018.11.21.23.16.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 23:16:33 -0800 (PST) Sender: Mark Johnston Date: Thu, 22 Nov 2018 02:16:29 -0500 From: Mark Johnston To: Kyle Evans Cc: Justin Hibbits , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Li-Wen Hsu Subject: Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc Message-ID: <20181122071629.GA96830@raichu> References: <201810210208.w9L28vVc080088@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 586998F2CF X-Spamd-Result: default: False [-2.33 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-0.98)[-0.981,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; NEURAL_HAM_LONG(-0.98)[-0.980,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.28)[ip: (2.56), ipnet: 2607:f8b0::/32(-2.31), asn: 15169(-1.57), country: US(-0.09)]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[2.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.37)[-0.373,0]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 07:16:36 -0000 On Wed, Nov 21, 2018 at 10:02:15PM -0600, Kyle Evans wrote: > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits wrote: > > > > > > Author: jhibbits > > > Date: Sun Oct 21 02:08:57 2018 > > > New Revision: 339516 > > > URL: https://svnweb.freebsd.org/changeset/base/339516 > > > > > > Log: > > > powerpc/dtrace: Use explicit bit numbers to mask out PSL_EE > > > > > > There seems to be a race in CI, such that dtrace_asm.S might be assembled > > > before the genassym is completed. This causes a build failure when PSL_EE > > > doesn't exist, and is read as 0. Get around this by explicitly specifying > > > the bits in the mask instead. > > > > > > > Hi, > > > > CI on the stable/12 branch still hits this, so I'm tempted to MFC this > > if you don't object. OTOH, the correct solution should be a > > `dependency "genassym.o"` in ^/sys/conf/files.powerpc for > > dtrace_asm.S, no? I believe that dtrace_asm.S will be built as part of dtrace.ko, not the kernel. dtrace/Makefile already specifies a dependency on assym.inc. Maybe this is the same issue as PR 233339? > Sorry, that should have read "genassym.inc" -- my naive understanding > of 'dependency' is that config(8) will turn it directly into a > makefile dependency that will alleviate this. >