From nobody Wed Sep 7 19:14:41 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MNBlV3vwhz4bvMW; Wed, 7 Sep 2022 19:14:46 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MNBlV2tVBz3Hrt; Wed, 7 Sep 2022 19:14:46 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662578086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lj2jpi90bBtOtC7rUCPAayzaa4ft5jefdKe/F9/y6RY=; b=AAZqDHFFa4ogrFXhNgpn8xcRLulflNg8KaXlhkPrH0IZ9aifgmb/eJYdsSyM8wtE5/QekG u6d7OnM5Ixyt/86OrRKF70nXtr2CPGti/nSaZvfO0ydXC7ry7JF5WHyuhtJUlBRC3Ot+vq TM9YBR1EIBs4qn+cfzaIOMvO1bPi2tyahamPAAcM6v0CuA1VXcwEHVPjIjcaZaH/5gEkSy ZtwP9rXdFxcPmVKcxl7k6iqZSJkGW47SOyjrhC07lZ9t5/sddOtuG/rVTgfvobyf/HNAHg N9NAMx3gBh1agrA75gX7evkz+2tCQv+59+PxoQlBhK+kR+AqTYEPJqn1WaikeQ== Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MNBlV0TJGz15Nl; Wed, 7 Sep 2022 19:14:46 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 949CC8D4A345; Wed, 7 Sep 2022 19:14:44 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 94A495C3A82F; Wed, 7 Sep 2022 19:14:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id P4xemU8YOYyn; Wed, 7 Sep 2022 19:14:42 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 19A1D5C3A832; Wed, 7 Sep 2022 19:14:42 +0000 (UTC) Date: Wed, 7 Sep 2022 19:14:41 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e72c522858cb - main - divert(4): make it compilable and working without INET In-Reply-To: Message-ID: References: <202208302249.27UMnSwI022109@gitrepo.freebsd.org> <6q6n8553-2143-n24p-4816-406549997s@mnoonqbm.arg> <15on1poo-pnpq-3pos-qs7s-673pp1q0s83@serrofq.bet> <6r5o5nqn-9srp-79qr-n33-q4992936q51q@serrofq.bet> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662578086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lj2jpi90bBtOtC7rUCPAayzaa4ft5jefdKe/F9/y6RY=; b=OTyg194+MGwvnyWAstNGW2FD9x+dJ+xIVYSa0Tpv6JE+DtH8K+DJd7NVcA/B3MPBF5ZpbA phs35sMy52H5T0aCqAztg7nhDK+4zXzAP/2LlQdXe/qjGdXgW/RbXqzknqKWLnyy4z3+vC sB7Y/Pvy5/h5m/Cb1WXYl9LTODLsFWPMnFVCw2vlJl0eDqCSi6ZyiA/Os8qA/275WzjWlA KYQxKlwcAzC8ml6+kbUtasYH2dMAemsCPh2j/2efqW96PqARmUdBca5b6GKszF/BfJT6vN digNLphYZs6HqZDMQ/63dcjJx+hAPJjj59budcNzE2PLdQUD1m+HO/0KwS8OaA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662578086; a=rsa-sha256; cv=none; b=AwLsmSpfqL8ILbHqnbbOtpmajyTSnCpusHhU/sHTHKqxhSYeRXsBbSNd2btPbTvcgxXrek YQdX+T/ivVPJR6smXvaGREQz5onpZD0KLoLpQPSTlSc5FK6Krog14xsk30FbRHdi8oHDxh e4zl682FsDkie8t9yX4wBtmDzwF7Vrcp96X4eRY1k2U8fqfeyNCKlPdJUvi9Og1E4BI/T4 ZT2KSxh/oa7wciV/aklRaNt+XMq9yUBJ6hoOHfEVGXWzsquWHJWf6KSXnQg+VFxVJ2gUdT 51mQOxXzYVgbMXD6fzChbyDJJ740ru4/DoGcrA9i1+BO4n3GMnXUfvCQ2D7xtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, 7 Sep 2022, Gleb Smirnoff wrote: > On Wed, Sep 07, 2022 at 06:16:07PM +0000, Bjoern A. Zeeb wrote: > B> > B> > On Sun, Sep 04, 2022 at 06:39:53AM +0000, Bjoern A. Zeeb wrote: > B> > B> > B> > B> > Author: Gleb Smirnoff > B> > B> > B> > B> > AuthorDate: 2022-08-30 22:09:21 +0000 > B> > B> > B> > B> > Commit: Gleb Smirnoff > B> > B> > B> > B> > CommitDate: 2022-08-30 22:09:21 +0000 > B> > B> > B> > B> > > B> > B> > B> > B> > divert(4): make it compilable and working without INET > B> > B> > B> > B> > > B> > B> > B> > B> > Differential revision: https://reviews.freebsd.org/D36383 > B> > B> > B> > B> > B> > B> > B> > B> Well, almost at least.... > B> > B> > B> > > B> > B> > B> > I wonder why LINT-NOINET builds without this?? > B> > B> > B> > B> > B> > B> I wondered the same last night.. I would be good to find out? > B> > B> > > B> > B> > Ok, I think that assumption that sysctl parts of divert require > B> > B> > INET were just wrong, that's why LINT-NOINET builds. > B> > B> > B> > B> Not entirely. It's because sys/netinet/in_proto.c uncodonitionally > B> > B> currently provides _net_inet for the sysctl. > B> > B> The reason for that is that a lot of AF independent sysctls were initially > B> > B> put under inet but are equally used for inet6 or neither in the network stack. > B> > B> > B> > B> You will need at least #if defined(INET6) || defined(INET) around the sysctls > B> > B> in divert.c then. > B> > B> > B> > B> A LINT-NOIP kernel will complain about the missing symbol if we keep compiling > B> > B> divert without INET or INET6 in the kernel: > B> > > B> > My goal was not to make divert(4) supported on NOIP kernel. The goal was to make > B> > it supported on NOINET, an IPv6 only kernel. I don't see any value for divert(4) > B> > on a kernel without either stack. > B> > B> then we should stop compiling it in that case. > > Do we compile it for NOIP? oh you fixed it this morning here in aa74cc6d6f995. Thanks! Case closed :) -- Bjoern A. Zeeb r15:7