From owner-cvs-all@FreeBSD.ORG Thu Jan 5 09:18:57 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F9EF16A41F; Thu, 5 Jan 2006 09:18:57 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 574C143D72; Thu, 5 Jan 2006 09:18:55 +0000 (GMT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k059Injr089730; Thu, 5 Jan 2006 09:18:50 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k059Inrv089729; Thu, 5 Jan 2006 09:18:49 GMT (envelope-from bde) Message-Id: <200601050918.k059Inrv089729@repoman.freebsd.org> From: Bruce Evans Date: Thu, 5 Jan 2006 09:18:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/msun/src s_cbrtf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2006 09:18:57 -0000 bde 2006-01-05 09:18:48 UTC FreeBSD src repository Modified files: lib/msun/src s_cbrtf.c Log: Oops, on amd64 (and probably on all non-i386 systems), the previous commit broke the 2**24 cases where |x| > DBL_MAX/2. There are exponent range problems not just for denormals (underflow) but for large values (overflow). Doubles have more than enough exponent range to avoid the problems, but I forgot to convert enough terms to double, so there was an x+x term which was sometimes evaluated in float precision. Unfortunately, this is a pessimization with some combinations of systems and compilers (it makes no difference on Athlon XP's, but on Athlon64's it gives a 5% pessimization with gcc-3.4 but not with gcc-3.3). Exlain the problem better in comments. Revision Changes Path 1.16 +11 -6 src/lib/msun/src/s_cbrtf.c