From owner-svn-src-head@freebsd.org Tue Feb 26 20:59:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C558C1503C00; Tue, 26 Feb 2019 20:59:30 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1CC8D72E5B; Tue, 26 Feb 2019 20:59:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id yjosgLwPKgaEyyjougMuE5; Tue, 26 Feb 2019 13:59:21 -0700 X-Authority-Analysis: v=2.3 cv=QOMWuTDL c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=O9OwvyCs5SItpUZL52UA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id D8A5C614; Tue, 26 Feb 2019 12:59:17 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x1QKwwmr018231; Tue, 26 Feb 2019 12:58:58 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x1QKwvJn018213; Tue, 26 Feb 2019 12:58:57 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201902262058.x1QKwvJn018213@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: John Baldwin cc: rgrimes@freebsd.org, Benjamin Kaduk , Cy Schubert , Baptiste Daroussin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common In-Reply-To: Message from John Baldwin of "Tue, 26 Feb 2019 09:19:02 -0800." <20a4a5ab-f088-537b-8666-e6c6f43170a9@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 26 Feb 2019 12:58:57 -0800 X-CMAE-Envelope: MS4wfNVYaGp+oBhNMMas7s2I3pD6Nt9GQqP6keHzhZOUCA6RNNL8N3CDandIg1/ZBlN2QUPIDEueatdAm6btDZkYrYPi0TLSWCK1jLEdkbFY1VLYTw+wAsie gXJFSWbh5DUBsZeCIrgh+LRBmADsrLuC1uz2xwhVMAV/foXypnbOVSjUtL0GqRA9M5JzKuWGAs2G11qalVoSRrcuFkRW41UWcuho24CPOXlrNFDJHwMKodwu nZN4h7pBBFUUrP3vzBd0lLbOEH180aClQSQJvbT9pJzZptK+bspC5ZjHcQTp66UqARkn65OaTovzURtPA+CnAArENtgwqwj6JhOWa871mH4C++2TcSYL28xm YEkr4s5XskFFMNCz8VK15Sux13u9Tw== X-Rspamd-Queue-Id: 1CC8D72E5B X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.84 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.15)[ip: (-5.90), ipnet: 64.59.128.0/20(-2.66), asn: 6327(-2.09), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[12.134.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 20:59:31 -0000 In message <20a4a5ab-f088-537b-8666-e6c6f43170a9@FreeBSD.org>, John Baldwin wri tes: > On 2/26/19 8:59 AM, Rodney W. Grimes wrote: > >> On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert > >> wrote: > >> > >>> On February 26, 2019 7:48:27 AM PST, Cy Schubert < > >>> Cy.Schubert@cschubert.com> wrote: > >>>> On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > >>>> wrote: > >>> > >> > >> [trimming the unneeded pile of commit body] > >> > >> > >>>> This broke my systems, many filesystems fail to mount causing nullfs > >>>> late mounts to fail. No details now until tonight. > >>>> > >>>> Suggest we back this out until it is properly tested. > >>> > >>> Nested zfs filesystems seem not to be handled properly or possibly not > >>> supported any more. This explains my mail gateway also not mounting all > >>> filesystems in /home. It was odd that dovecot stopped working. > >>> > >>> The symptom of the problem is zfs mount -a no longer mounts all > >>> filesystems. Zfs mount fails saying the filesystem is already mounted. Th > e > >>> workaround is to zfs umount each affected zfs dataset by hand and zfs mou > nt > >>> it by hand. > >>> > >>> Generally this has screwed up sites that have hundreds (in my case 122) > >>> zfs datasets. The work around might be to script testing each mount, > >>> unmounting and remounting if necessary. > >>> > >>> I'm being sarcastic about creating an rc script to clean this up. This > >>> needs to be backed out and tested properly before being committed. > >>> > >>> > >> I don't know what you mean by "nested zfs filesystems" -- do you mean a > >> zpool within a zvol? > >> That has been unsupported for a long time, IIRC. And > > That had better not be unsupported, that is the prefered technology > > for all of the virtualization stuff, bhyve, virtualbox, qemu, etc. > > I think Ben is referring to using the nested zpool on the host itself rather > than in the guest. We do actually let you do such crazy things I think (I > use UFS in my VMs usually and fsck on the host against /dev/zvol/bhyve/p > 2 > can be faster than fsck in the booted guest), but normally the host just host > s > the zvol and the guest manages filesystems in the volume. Mounting the > nested zpool on the host is probably best characterized as running with > scissors. I was talking about nested datasets, i.e. tank/freebsd/git/current and tank/freebsd/git/ports are four levels deep. In my case the ports dataset was mounted while the current dataset was not, though zfs believed it was. unmounting the current dataset and remounting it, zfs umount .../current; zfs mount .../current worked around the issue. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.