From owner-svn-ports-head@freebsd.org  Wed Aug 30 20:36:51 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D1E0E09BAD;
 Wed, 30 Aug 2017 20:36:51 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3EFAB7F33C;
 Wed, 30 Aug 2017 20:36:51 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 7ED896C44; Wed, 30 Aug 2017 20:36:50 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Dan Langille <dvl@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r448998 - head/net-mgmt/tcpreplay
References: <201708301932.v7UJW1tH094312@repo.freebsd.org>
Date: Wed, 30 Aug 2017 22:36:44 +0200
In-Reply-To: <201708301932.v7UJW1tH094312@repo.freebsd.org> (Dan Langille's
 message of "Wed, 30 Aug 2017 19:32:01 +0000 (UTC)")
Message-ID: <1sns-okrn-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Aug 2017 20:36:51 -0000

Dan Langille <dvl@FreeBSD.org> writes:

> Author: dvl
> Date: Wed Aug 30 19:32:00 2017
> New Revision: 448998
> URL: https://svnweb.freebsd.org/changeset/ports/448998
>
> Log:
>   Add base/port options for libpcap
[...]
> +OPTIONS_DEFINE=	LIBPCAP_BASE LIBPCAP_PORTS
[...]
> +OPTIONS_SINGLE=	SG1
> +OPTIONS_SINGLE=	LIBPCAP_BASE LIBPCAP_PORTS

_SINGLE declares a group of options, not the option themselves.
When _SINGLE is overloaded by _DEFINE the option is no longer exclusive.

Did you forget to adjust Porter's Handbook example?

OPTIONS_SINGLE=	LIBPCAP
OPTIONS_SINGLE_LIBPCAP=	LIBPCAP_BASE LIBPCAP_PORTS

> +OPTIONS_DEFAULT=	LIBPCAP_BASE

Doesn't work if net/libpcap is installed as a dependency by another
(unrelated) port.

> +LIBPCAP_PORTS_BUILD_DEPENDS=	${LOCALBASE}/lib/libpcap.a:net/libpcap
> +LIBPCAP_PORTS_LIB_DEPENDS=	libpcap.so:net/libpcap

Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS.