From owner-freebsd-ports Sat Mar 4 16: 0: 9 2000 Delivered-To: freebsd-ports@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id C5FF437B927 for ; Sat, 4 Mar 2000 16:00:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id QAA46686; Sat, 4 Mar 2000 16:00:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from mfo01.iij.ad.jp (mfo01.iij.ad.jp [202.232.2.118]) by hub.freebsd.org (Postfix) with ESMTP id 9EAF137B91E for ; Sat, 4 Mar 2000 15:54:00 -0800 (PST) (envelope-from sada@rr.iij4u.or.jp) Received: from rr.iij4u.or.jp (rr.iij4u.or.jp [210.130.0.42]) by mfo01.iij.ad.jp (8.8.8/MFO1.3) with ESMTP id IAA16479 for ; Sun, 5 Mar 2000 08:53:59 +0900 (JST) Received: from localhost (h138.p104.iij4u.or.jp [210.130.104.138]) by rr.iij4u.or.jp (8.8.8+2.2IIJ/4U1.1) with ESMTP id IAA09671 for ; Sun, 5 Mar 2000 08:53:58 +0900 (JST) Message-Id: <20000305085346J.sada@rr.iij4u.or.jp> Date: Sun, 05 Mar 2000 08:53:46 +0900 From: sada@FreeBSD.ORG Reply-To: sada@FreeBSD.ORG To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.2 Subject: ports/17193: leafnode+ package doesn't build spool dir. Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 17193 >Category: ports >Synopsis: leafnode+ package doesn't build spool dir. now. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Mar 4 16:00:01 PST 2000 >Closed-Date: >Last-Modified: >Originator: SADA Kenji >Release: FreeBSD 3.4-STABLE i386 >Organization: Nagoya.Aichi.Japan >Environment: FreeBSD 3.4-STABLE i386 XFree86 3.3.5 >Description: Tom, the port maintainer has removed description about variable 'LEAFNODE_SETUP_WRKDIRS' and make the port to always setup spool directory. But forgot about package and now package users have no way to setup spool directory. >How-To-Repeat: pkg_add without setting the environment 'LEAFNODE_SETUP_WRKDIRS'. >Fix: Port and package should act in same way as far as it can. I believe that one function should be written in one place and it would be better that ports makefile calls INSTALL script. I recommend below patch if Tom decided to cancel 'LEAFNODE_SETUP_WRKDIRS' works. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/news/leafnode+/Makefile,v retrieving revision 1.13 diff -u -w -r1.13 Makefile --- Makefile 2000/01/24 21:26:47 1.13 +++ Makefile 2000/03/04 23:15:57 @@ -47,19 +47,8 @@ @${INSTALL_DATA} ${WRKSRC}/${file} ${PREFIX}/share/doc/leafnode+ .endfor .endif -.if !exists{LEAFSPOOLDIR} || !exists{{LEAFLIBDIR} - @${MKDIR} ${LEAFSPOOLDIR} ${LEAFLIBDIR} - @${MKDIR} ${LEAFSPOOLDIR}/interesting.groups - @${MKDIR} ${LEAFSPOOLDIR}/out.going -.for dir_a in 0 1 2 3 4 5 6 7 8 9 -.for dir_b in 0 1 2 3 4 5 6 7 8 9 -.for dir_c in 0 1 2 3 4 5 6 7 8 9 - @${MKDIR} ${LEAFSPOOLDIR}/message.id/${dir_a}${dir_b}${dir_c} -.endfor -.endfor -.endfor - @${CHOWN} -R news:news ${LEAFSPOOLDIR} ${LEAFLIBDIR} - @${CHMOD} 2750 ${LEAFSPOOLDIR} -.endif + +post-install: + @PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL .include Index: files/INSTALL.in =================================================================== RCS file: /home/ncvs/ports/news/leafnode+/files/INSTALL.in,v retrieving revision 1.3 diff -u -w -r1.3 INSTALL.in --- files/INSTALL.in 1999/08/30 14:31:42 1.3 +++ files/INSTALL.in 2000/03/04 23:17:48 @@ -1,8 +1,8 @@ #!/bin/sh -# $FreeBSD: /home/ncvs/ports/news/leafnode+/files/INSTALL.in,v 1.3 1999/08/30 14:31:42 peter Exp $ +# $FreeBSD: ports/news/leafnode+/files/INSTALL.in,v 1.3 1999/08/30 14:31:42 peter Exp $ LIBDIR=@LIBDIR@ SPOOLDIR=@SPOOLDIR@ -if [ x$2 = xPOST-INSTALL -a x$LEAFNODE_SETUP_WRKDIRS != x ]; then +if [ x$2 = xPOST-INSTALL ]; then if [ ! -d $LIBDIR ]; then mkdir -p $LIBDIR chown -R news.news $LIBDIR/. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message