From owner-svn-src-all@FreeBSD.ORG Thu Jun 16 18:13:02 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88014106566B; Thu, 16 Jun 2011 18:13:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 0BFFA8FC13; Thu, 16 Jun 2011 18:13:01 +0000 (UTC) Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p5GI1oWr019868 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Thu, 16 Jun 2011 12:01:51 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Thu, 16 Jun 2011 12:01:38 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <43730304-8D75-47A3-B09C-67E61017592A@bsdimp.com> References: <201106161535.p5GFZCb7034904@svn.freebsd.org> To: Garrett Cooper X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Thu, 16 Jun 2011 12:01:52 -0600 (MDT) Cc: Tai-hwa Liang , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223151 - head/lib/libstand X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2011 18:13:02 -0000 On Jun 16, 2011, at 11:40 AM, Garrett Cooper wrote: > On Thu, Jun 16, 2011 at 8:53 AM, Warner Losh wrote: >>=20 >> On Jun 16, 2011, at 9:35 AM, Tai-hwa Liang wrote: >>=20 >>> Author: avatar >>> Date: Thu Jun 16 15:35:12 2011 >>> New Revision: 223151 >>> URL: http://svn.freebsd.org/changeset/base/223151 >>>=20 >>> Log: >>> Using the correct format string(%zu) for size_t type. This should = fix 64 >>> bits builds. >>>=20 >>> Submitted by: Garrett Cooper >>=20 >> How about we hold all fixes until it *ACTUALLY* builds on all = universe platforms? >>=20 >> I hate to be cranky, but build breakage costs a lot of time. And for = stupid stuff like this? I'm inclined to force WARNS=3D0 until people = can actually fix it right. >=20 > This was stupid breakage on my part for not running this through > universe first. The patch that builds upon this that I submitted in > the other thread so far _does_ unbreak universe on ia64 and mips*. > Still working on getting it to pass through amd64, i386, and sparc64 > at least, which is going to be a few more hours because for some magic > reason make -j doesn't work for me with universe. I've reverted to WARNS=3D0. Once the patches are in and work for make = universe, we can put it back to WARNS=3D2. Warner