From owner-cvs-all@FreeBSD.ORG Tue Aug 19 14:04:23 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA46616A4BF; Tue, 19 Aug 2003 14:04:23 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73A3B43F93; Tue, 19 Aug 2003 14:04:22 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from athlon.pn.xcllnt.net (athlon.pn.xcllnt.net [192.168.4.3]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h7JL4MwO012520; Tue, 19 Aug 2003 14:04:22 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from athlon.pn.xcllnt.net (localhost [127.0.0.1]) by athlon.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h7JL4M8j053142; Tue, 19 Aug 2003 14:04:22 -0700 (PDT) (envelope-from marcel@athlon.pn.xcllnt.net) Received: (from marcel@localhost) by athlon.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h7JL4LbM053137; Tue, 19 Aug 2003 14:04:21 -0700 (PDT) (envelope-from marcel) Date: Tue, 19 Aug 2003 14:04:21 -0700 From: Marcel Moolenaar To: Garrett Wollman Message-ID: <20030819210421.GA28597@athlon.pn.xcllnt.net> References: <200308192039.h7JKdni9081097@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200308192039.h7JKdni9081097@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include unistd.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Aug 2003 21:04:24 -0000 On Tue, Aug 19, 2003 at 01:39:49PM -0700, Garrett Wollman wrote: > wollman 2003/08/19 13:39:49 PDT > > FreeBSD src repository > > Modified files: > include unistd.h > Log: > Update gethostname() prototype to match source and standard. Changing the type of the namelen argument from int to size_t in at least the implementation of the function breaks the ABI on 64-bit platforms. The problem is that sign-extension is moved from the callee to the caller and previously compiled code will not have said sign-extension. Since the namelen argument is used to specify the size of the name array, we now have a possible undetected buffer overrun due to garbage in the upper 32-bit). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net