From owner-freebsd-bugs@freebsd.org  Tue Nov 14 16:59:49 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B636DD7443
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue, 14 Nov 2017 16:59:49 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 29A7765AA4
 for <freebsd-bugs@FreeBSD.org>; Tue, 14 Nov 2017 16:59:49 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAEGxnV3034844
 for <freebsd-bugs@FreeBSD.org>; Tue, 14 Nov 2017 16:59:49 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 223553] bsdgrep in -current is 10 times slower than before
Date: Tue, 14 Nov 2017 16:59:49 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: regression
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: kevans@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-223553-8-uLrjUcXrnc@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-223553-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-223553-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 16:59:49 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223553

--- Comment #3 from Kyle Evans <kevans@freebsd.org> ---
In testing, I've found that flipping GNU_GREP_COMPAT off by default in -HEA=
D is
what caused the slowdown. Comparable performance can be achieved by turning=
 it
back on, which leads me to the conclusion that our regex(3) is the source of
slowdown in this instance.

I think this leads me to two conclusions:

1.) Our regex(3) implementation needs optimized or replaced
2.) We need to improve our usage of regex(3)

These are both important, but #2 is something we've been needing to do anyw=
ays
and probably the lower-hanging fruit. I think this would be accomplished by
calling regex(3) less with larger chunks of text, rather than breaking up t=
ext
line-by-line. This would allow us to take advantage of the optimizations to=
 be
had with larger subject strings and reduce the overhead (in most cases) by =
no
longer having to search for all newlines.

--=20
You are receiving this mail because:
You are the assignee for the bug.=