From owner-svn-src-head@FreeBSD.ORG Sat Dec 8 17:41:40 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0012314D; Sat, 8 Dec 2012 17:41:39 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id D6C898FC15; Sat, 8 Dec 2012 17:41:39 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qB8HfdlD086119; Sat, 8 Dec 2012 17:41:39 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id qB8HfdQJ086118; Sat, 8 Dec 2012 17:41:39 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201212081741.qB8HfdQJ086118@svn.freebsd.org> From: Jilles Tjoelker Date: Sat, 8 Dec 2012 17:41:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r244034 - head/usr.bin/time X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Dec 2012 17:41:40 -0000 Author: jilles Date: Sat Dec 8 17:41:39 2012 New Revision: 244034 URL: http://svnweb.freebsd.org/changeset/base/244034 Log: time: Use close-on-exec instead of fclose() in the child process. Modified: head/usr.bin/time/time.c Modified: head/usr.bin/time/time.c ============================================================================== --- head/usr.bin/time/time.c Sat Dec 8 15:11:09 2012 (r244033) +++ head/usr.bin/time/time.c Sat Dec 8 17:41:39 2012 (r244034) @@ -112,7 +112,7 @@ main(int argc, char **argv) argv += optind; if (ofn) { - if ((out = fopen(ofn, aflag ? "a" : "w")) == NULL) + if ((out = fopen(ofn, aflag ? "ae" : "we")) == NULL) err(1, "%s", ofn); setvbuf(out, (char *)NULL, _IONBF, (size_t)0); } @@ -123,8 +123,6 @@ main(int argc, char **argv) err(1, "time"); /* NOTREACHED */ case 0: /* child */ - if (ofn) - fclose(out); execvp(*argv, argv); err(errno == ENOENT ? 127 : 126, "%s", *argv); /* NOTREACHED */