Date: Tue, 23 Mar 2021 20:00:18 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Jochen Neumeister <joneum@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r569017 - head/databases/mysql57-server Message-ID: <YFo6wvpNciSSK6Dv@KGPE-D16> In-Reply-To: <650caf6e-5ab6-ec52-7cde-c77757a5d019@FreeBSD.org> References: <202103231049.12NAnNUa027511@repo.freebsd.org> <650caf6e-5ab6-ec52-7cde-c77757a5d019@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--w9EYvfCNFtHznWXW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hello,
as Chris already mentioned, this is under a blanket approval.
I think we can all agree that it's a simple and trivial patch.
I also think that it's simple enough that it would be hard to actually impr=
ove it (e.g. there are no helpers, so you wouldn't be able to suggest setti=
ng e.g. LLD_UNSAFE_powerpc).
It also doesn't break anything, because there is .if ${ARCH}.
On 21-03-23 18:14:48, Jochen Neumeister wrote:
> It would be nice if you at least write an eMail before that you want to=
=20
> change something on someone else's port .....
>=20
> Jochen
>=20
>=20
>=20
> Am 23.03.21 um 11:49 schrieb Piotr Kubaj:
> > Author: pkubaj
> > Date: Tue Mar 23 10:49:23 2021
> > New Revision: 569017
> > URL: https://svnweb.freebsd.org/changeset/ports/569017
> >
> > Log:
> > databases/mysql57-server: don't use LLD for linking on powerpc
> > =20
> > LLD currently fails:
> > ld: error: relocation refers to a discarded section: .rodata._ZN5boo=
st6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4=
_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_mana=
ger_operation_typeEN4mpl_5bool_ILb0EEE
> > >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(obj=
ect_filter.cc.o)
> > >>> referenced by object_filter.cc
> > >>> object_filter.cc.o:(.got2+0x108) in archive ../../=
archive_output_directory/libmysqlpump_lib.a
> > =20
> > ld: error: relocation refers to a discarded section: .rodata._ZN5boo=
st6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4=
_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_mana=
ger_operation_typeEN4mpl_5bool_ILb0EEE
> > >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(sql=
_formatter.cc.o)
> > >>> referenced by sql_formatter.cc
> > >>> sql_formatter.cc.o:(.got2+0x130) in archive ../../=
archive_output_directory/libmysqlpump_lib.a
> > =20
> > ld: error: relocation refers to a discarded section: .rodata._ZN5boo=
st6detail8function15functor_managerINS_9algorithm6detail13token_finderFINS4=
_10is_any_ofFIcEEEEE7managerERKNS1_15function_bufferERSA_NS1_30functor_mana=
ger_operation_typeEN4mpl_5bool_ILb0EEE
> > >>> defined in ../../archive_output_directory/libmysqlpump_lib.a(tab=
le.cc.o)
> > >>> referenced by table.cc
> > >>> table.cc.o:(.got2+0x50) in archive ../../archive_o=
utput_directory/libmysqlpump_lib.a
> > clang++: error: linker command failed with exit code 1 (use -v to se=
e invocation)
> >
> > Modified:
> > head/databases/mysql57-server/Makefile
> >
> > Modified: head/databases/mysql57-server/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/databases/mysql57-server/Makefile Tue Mar 23 10:47:46 2021 (r5=
69016)
> > +++ head/databases/mysql57-server/Makefile Tue Mar 23 10:49:23 2021 (r5=
69017)
> > @@ -174,6 +174,10 @@ CC=3D ${LOCALBASE}/bin/clang${LLVM_DEFAULT}
> > CXX=3D ${LOCALBASE}/bin/clang++${LLVM_DEFAULT}
> > .endif
> > =20
> > +.if ${ARCH} =3D=3D powerpc
> > +LLD_UNSAFE=3D yes
> > +.endif
> > +
> > post-extract:
> > @${RM} -rv ${WRKSRC}/sql/sql_hints.yy.cc ${WRKSRC}/sql/sql_hints.yy.h
> > =20
--w9EYvfCNFtHznWXW
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmBaOsEACgkQelmbhSCD
nJ0gqw//Tc4rvD2vO69mp+IByB+V1SDrwD74PYWoDsnVpnAPPm+6auSL0XYilr7Q
TK1Z8kFTdWyroJy0Qai+zdI3SETh4FMwQmr3pwycktwr4UiciJs7/pyZ6eG7W4t4
dJZb06zu7TAUTlCKwxeTZem5IklJCdmBwmTOwMgicg+lzxMgKfS+9hABJRlUoa0m
g6pMW/Q9EUn/CiiWfPydlnizOhgjtaX+lPNYFC0xGo3UcsEMjlc+a4IBG/L/qWPm
SY9EwpuFr3oImsxxVi3Z6n58sJimfyCwKnSytNOd/lmaGF+szJPCacNm5h9h4bmx
kDFe/AhtVrsary+9rf4LMhPMYgc1KvFuDR7JDVnWJiYMjcViqGVoWUQm6QRvtAf4
5YGnFss4yfLMKPbArQNw+MH10VM39g88Ma8gFbceVtLQXScUJXmRus+54lLJS+PJ
ugiryLFfD0rx3k2RBHaW1X639DJTuTwG8OO3ln/HZvb5g//iuxPg8l9FyFcx4LDS
2YmpnmuK6AvN+YxIDNJ94Ki8DrBIt4eWYxU7GDhMUEnnwutZabuKMSFGIzorzZdh
xfXtBH8UWF/33+6v3eXbCFR14U5HTwz0moYXaM7gtcKeoA8eZ+RCiLT+i6I4LPV0
GL+4kfEpeGdyvFdUZxR1hLfybprNOb1xvatz29YkJBQQ5u9eoAc=
=5GgF
-----END PGP SIGNATURE-----
--w9EYvfCNFtHznWXW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YFo6wvpNciSSK6Dv>