From owner-freebsd-current@FreeBSD.ORG Fri May 11 18:41:57 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82B4C16A403 for ; Fri, 11 May 2007 18:41:57 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 40AE913C447 for ; Fri, 11 May 2007 18:41:57 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: by an-out-0708.google.com with SMTP id d23so249804and for ; Fri, 11 May 2007 11:41:56 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=r1N+qZTa7lwnHUJDIwQaB5Dx6vDM1dtK+tbnpztLaCv7fVj87bITRQ0d9i3Wmrx+X0srQmnlk2YZGhffUkNwMrhKqr6O4zd/8JdQ0JPbf248FrkjRx3SoqBcwvUexZSC2yUIONemI3yHsJ4Z2pGK0Z13+EdTy0geGacmsa1hh7U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=X/ZIqbLvrWwX4iJCca/1Wo5qXBCxM0EjRZc9DPyfEK3Jt8d1V0iQjgYb82K1wCokRkb7nfKoVujM0NhGGfvYG0F9YLtqoqmrbdkgW1906Zu6hqsq4Uboat2duAx2TpjA2aB9mIlVX8+/dI0V6B4MaFCjte5tA7iXeCEvTILOOFw= Received: by 10.100.240.19 with SMTP id n19mr2441907anh.1178908916080; Fri, 11 May 2007 11:41:56 -0700 (PDT) Received: by 10.100.139.10 with HTTP; Fri, 11 May 2007 11:41:56 -0700 (PDT) Message-ID: <790a9fff0705111141n3731f75at23aae6f0482bd638@mail.gmail.com> Date: Fri, 11 May 2007 13:41:56 -0500 From: "Scot Hetzel" To: freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_155205_17368898.1178908916030" Subject: mdconfig not returning error when listing a non-existing device. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2007 18:41:57 -0000 ------=_Part_155205_17368898.1178908916030 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I created a vnode filesystem to use with mdconfig and added it to the /etc/rc.conf file: mdconfig2_enable="YES" mdconfig2_list="md99" #ncvs filesystem to be mounted by zfs mdconfig_md99="-t vnode -f /usr/home/ncvs.dsk" The problem is that when the mdconfig2 rc script is executed, it fails to create the md device. hp010# ls /dev/md* /dev/mdctl hp010# /etc/rc.d/mdconfig2 start md99 /etc/rc.d/mdconfig2: DEBUG: run_rc_command: start_precmd: [ -n "${_mdconfig2_list}" ] /etc/rc.d/mdconfig2: DEBUG: load_kld: geom_md kernel module already loaded. /etc/rc.d/mdconfig2: DEBUG: run_rc_command: doit: mdconfig2_start /etc/rc.d/mdconfig2: DEBUG: md99 config: -t vnode -f /usr/home/ncvs.dsk /etc/rc.d/mdconfig2: DEBUG: md99 type: vnode /etc/rc.d/mdconfig2: DEBUG: md99 dev: /dev/md99 /etc/rc.d/mdconfig2: DEBUG: md99 file: /usr/home/ncvs.dsk /etc/rc.d/mdconfig2: DEBUG: md99 fs: /usr/home /etc/rc.d/mdconfig2: DEBUG: md99 owner: /etc/rc.d/mdconfig2: DEBUG: md99 perms: /etc/rc.d/mdconfig2: DEBUG: md99 files: /etc/rc.d/mdconfig2: DEBUG: md99 populate cmd: /etc/rc.d/mdconfig2: ERROR: md99 already exists This error comes from when it is checking if the device already exists: if mdconfig -l -u ${_md} >/dev/null 2>&1; then err 3 "${_md} already exists" fi The problem is that mdconfig -l doesn't return an error code when it is asked to list a non-existant device. hp010# ls /dev/md* /dev/mdctl hp010# mdconfig -l -u md99 ; echo $? 0 hp010# mdconfig -a -t vnode -f /usr/home/ncvs.dsk -u md99 ; echo $? 0 hp010# mdconfig -l -u md0 ; echo $? md0 vnode 5.0G /usr/home/ncvs.dsk 0 This problem affects both the /etc/rc.d/mdconfig and mdconfig2 scripts. Scot NOTE: The attached patch adds mdconfig[,2]_list - its use is to allow the scripts to configure md devices that don't start at 0. -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised. ------=_Part_155205_17368898.1178908916030 Content-Type: text/x-diff; name=mdconfig.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f1kz5szb Content-Disposition: attachment; filename="mdconfig.patch" SW5kZXg6IG1kY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL2V0Yy9y Yy5kL21kY29uZmlnLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQKZGlmZiAtdSAtcjEuNCBtZGNv bmZpZwotLS0gbWRjb25maWcJMzEgRGVjIDIwMDYgMTA6Mzc6MTggLTAwMDAJMS40CisrKyBtZGNv bmZpZwkxMSBNYXkgMjAwNyAxODoxODo1MCAtMDAwMApAQCAtMTkxLDYgKzE5MSwxNCBAQAogCQkJ X21kY29uZmlnX3VuaXQ9JCgoJHtfbWRjb25maWdfdW5pdH0gKyAxKSkKIAkJZmkKIAlkb25lCisJ aWYgWyAtbiAiJHttZGNvbmZpZ19saXN0fSIgXSA7IHRoZW4KKwkJZm9yIF9tZGNvbmZpZ19kZXYg aW4gJHttZGNvbmZpZ19saXN0fSA7IGRvCisJCQlldmFsIF9tZGNvbmZpZ19jb25maWc9XCRtZGNv bmZpZ18ke21kY29uZmlnX2Rldn0KKwkJCWlmIFsgLW4gIiR7X21kY29uZmlnX2NvbmZpZ30iIF0g OyB0aGVuCisJCQkJX21kY29uZmlnX2xpc3Q9IiR7X21kY29uZmlnX2xpc3R9JHtfbWRjb25maWdf bGlzdDorIH0ke19tZGNvbmZpZ19kZXZ9IgorCQkJZmkKKwkJZG9uZQorCWZpCiBmaQogCQogcnVu X3JjX2NvbW1hbmQgIiR7X21kY29uZmlnX2NtZH0iCkluZGV4OiBtZGNvbmZpZzIKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvZXRjL3JjLmQvbWRjb25maWcyLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjQKZGlmZiAtdSAtcjEuNCBtZGNvbmZpZzIKLS0tIG1kY29uZmlnMgkzMSBE ZWMgMjAwNiAxMDozNzoxOCAtMDAwMAkxLjQKKysrIG1kY29uZmlnMgkxMSBNYXkgMjAwNyAxODox NTo1MyAtMDAwMApAQCAtMjIyLDYgKzIyMiwxNCBAQAogCQkJX21kY29uZmlnMl91bml0PSQoKCR7 X21kY29uZmlnMl91bml0fSArIDEpKQogCQlmaQogCWRvbmUKKwlpZiBbIC1uICIke21kY29uZmln Ml9saXN0fSIgXSA7IHRoZW4KKwkJZm9yIF9tZGNvbmZpZzJfZGV2IGluICR7bWRjb25maWcyX2xp c3R9IDsgZG8KKwkJCWV2YWwgX21kY29uZmlnMl9jb25maWc9XCRtZGNvbmZpZ18ke21kY29uZmln Ml9kZXZ9CisJCQlpZiBbIC1uICIke19tZGNvbmZpZzJfY29uZmlnfSIgXSA7IHRoZW4KKwkJCQlf bWRjb25maWcyX2xpc3Q9IiR7X21kY29uZmlnMl9saXN0fSR7X21kY29uZmlnMl9saXN0OisgfSR7 X21kY29uZmlnMl9kZXZ9IgorCQkJZmkKKwkJZG9uZQorCWZpCiBmaQogCQogcnVuX3JjX2NvbW1h bmQgIiR7X21kY29uZmlnMl9jbWR9Igo= ------=_Part_155205_17368898.1178908916030--