From owner-freebsd-mobile Thu Dec 18 17:47:18 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id RAA10647 for mobile-outgoing; Thu, 18 Dec 1997 17:47:18 -0800 (PST) (envelope-from owner-freebsd-mobile) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id RAA10642 for ; Thu, 18 Dec 1997 17:47:15 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id SAA20740; Thu, 18 Dec 1997 18:47:10 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id SAA18752; Thu, 18 Dec 1997 18:47:06 -0700 Date: Thu, 18 Dec 1997 18:47:06 -0700 Message-Id: <199712190147.SAA18752@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: hosokawa@ntc.keio.ac.jp (HOSOKAWA Tatsumi) Cc: faber@ISI.EDU, nate@mt.sri.com, ambrisko@whistle.com, freebsd-mobile@FreeBSD.ORG Subject: Re: In-Reply-To: <199712190142.KAA15429@afs.ntc.mita.keio.ac.jp> References: <199712182355.PAA24716@tnt.isi.edu> <199712190142.KAA15429@afs.ntc.mita.keio.ac.jp> X-Mailer: VM 6.29 under 19.15 XEmacs Lucid Sender: owner-freebsd-mobile@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > >> Well, it doesn't *break* anything, but it's icky. :-) I just have a > >> preference for configurable systems. I agree however that making a > >> parameter configurable that no one con configure isn't worth much > >> (other than as incentive to change the unconfigurable stuff). > > I think it'll cause problems on machines that have more than two > CardBus bridges, or machines that have both ISA PC-card controller and > CardBus bridges. Good call! > I think it'll be te better way: > > if (the legacy 16bit ioadder is left uninitialized, or initialized > to odd value) { > set it to 0x3e0 + (unit number * 2); > } > > or > > if (the legacy 16bit ioadder is left uninitialized) { > set it to 0x3e0 + (unit number * 2); > } > > sp->index = legacy 16bit ioaddr; Agreed. Thanks for the feedback! Nate