From owner-cvs-all@FreeBSD.ORG Tue Mar 30 07:18:55 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23387106567B for ; Tue, 30 Mar 2010 07:18:55 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A401D8FC0C for ; Tue, 30 Mar 2010 07:18:54 +0000 (UTC) Received: (qmail 29724 invoked by uid 399); 30 Mar 2010 07:18:54 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 30 Mar 2010 07:18:54 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BB1A5DC.8040304@FreeBSD.org> Date: Tue, 30 Mar 2010 00:18:52 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.8) Gecko/20100329 Thunderbird/3.0.3 MIME-Version: 1.0 To: "Matthew D. Fuller" References: <201003280552.o2S5qCVL069016@repoman.freebsd.org> <20100330070428.GE4122@over-yonder.net> In-Reply-To: <20100330070428.GE4122@over-yonder.net> X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/dns/dnsmasq Makefile ports/japanese/FreeWnn-server Makefile ports/mail/mailscanner Makefile ports/mail/mailscanner/files mta.in ports/mail/mailscanner-devel Makefile ports/mail/mailscanner-devel/files mta.in ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 07:18:55 -0000 On 03/30/10 00:04, Matthew D. Fuller wrote: > On Sun, Mar 28, 2010 at 05:52:12AM +0000 I heard the voice of > Doug Barton, and lo! it spake thus: >> >> 1.37 +0 -1 ports/mail/spamass-milter/Makefile > > This broke spamass-milter. > > -RC_SCRIPTS_SUB= PREFIX=${PREFIX} RC_SUBR=${RC_SUBR} > > This var is still called for in post-patch: > > @${SED} ${RC_SCRIPTS_SUB:S/$/!g/:S/^/ -e s!%%/:S/=/%%!/} \ > ${FILESDIR}/spamass-milter.in > ${WRKDIR}/spamass-milter Thanks for pointing this out, and my apologies to all affected (especially pgolluci). After testing the fix I just committed it to avoid continued breakage. I was fooled by the fact that the port is already using USE_RC_SUBR properly, but I failed to search for additional examples of RC_SCRIPTS_SUB elsewhere. That's my second rc_subr flavored pointy hat for the collection ... Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/