From owner-freebsd-stable Mon Oct 30 3:15:12 2000 Delivered-To: freebsd-stable@freebsd.org Received: from elsamss06947.elsevier.nl (elsamss06947.elsevier.nl [145.36.5.12]) by hub.freebsd.org (Postfix) with ESMTP id 1616437B479 for ; Mon, 30 Oct 2000 03:15:08 -0800 (PST) Received: from elsamss06948.elsevier.nl (unverified) by elsamss06947.elsevier.nl (Content Technologies SMTPRS 4.1.5) with ESMTP id for ; Mon, 30 Oct 2000 12:16:08 +0100 Received: from olorin.elsevier.nl (olorin.elsevier.nl [145.36.13.14]) by elsamss06948.elsevier.nl (2.6 Build 1 (Berkeley 8.8.6)/8.8.4) with ESMTP id MAA01190 for ; Mon, 30 Oct 2000 12:12:11 +0100 Received: from lap1.sohara.org (pooh.elsevier.nl [145.36.13.27]) by olorin.elsevier.nl (8.8.8/8.8.8) with SMTP id MAA13619 for ; Mon, 30 Oct 2000 12:15:02 +0100 (MET) Date: Mon, 30 Oct 2000 12:33:05 +0000 From: "Steve O'Hara-Smith" To: stable@freebsd.org Subject: Small patch to lpr - comments, review, commit ? Message-Id: <20001030123305.23573c0e.steveo@eircom.net> X-Mailer: Sylpheed version 0.3.28 (GTK+ 1.2.8; FreeBSD 4.1.1-STABLE; i386) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi, I have found that lpr does not pass the -C parameters to lpd unless burst header pages are being printed. Unfortunately apsfilter (ab)uses the -C parameters for printer mode control. The patch below moves pass through of the -C parameters out of the conditional block. As far as I can see this is never harmful. The patch is against -stable because that is what I am running, I don't expect -current is very (any) different. Index: lpr.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/lpr/lpr/lpr.c,v retrieving revision 1.32.2.1 diff -u -r1.32.2.1 lpr.c --- lpr.c 2000/06/27 19:55:40 1.32.2.1 +++ lpr.c 2000/10/28 16:27:10 @@ -326,6 +326,7 @@ seteuid(uid); card('H', host); card('P', person); + card('C', class); if (hdr && !pp->no_header) { if (jobname == NULL) { if (argc == 0) @@ -335,7 +336,6 @@ ? arg + 1 : argv[0]); } card('J', jobname); - card('C', class); card('L', person); } if (format != 'p' && Zflag != 0) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message