From owner-cvs-all@FreeBSD.ORG Tue Mar 23 21:35:04 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4029416A4CE; Tue, 23 Mar 2004 21:35:04 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2297843D3F; Tue, 23 Mar 2004 21:35:04 -0800 (PST) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2O5Z3Ge049565; Tue, 23 Mar 2004 21:35:03 -0800 (PST) (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2O5Z3QT049564; Tue, 23 Mar 2004 21:35:03 -0800 (PST) (envelope-from wpaul) Message-Id: <200403240535.i2O5Z3QT049564@repoman.freebsd.org> From: Bill Paul Date: Tue, 23 Mar 2004 21:35:03 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2004 05:35:04 -0000 wpaul 2004/03/23 21:35:03 PST FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c Log: The ndis_wlan_bssid_ex structure we retrieve in ndis_get_assoc() is variable length, so we should not be trying to copy it into a fixed length buffer, especially one on the stack. malloc() a buffer of the right size and return a pointer to that instead. Fixes a crash I discovered when testing whe a Cisco AP in infrastructure mode, which returns several information elements that make the ndis_wlan_bssid_ex structure larger than expected. Revision Changes Path 1.50 +11 -5 src/sys/dev/if_ndis/if_ndis.c