From owner-svn-src-all@FreeBSD.ORG  Tue Jan 17 17:30:03 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 607F3106564A;
	Tue, 17 Jan 2012 17:30:03 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
	[195.197.172.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E3FB8FC18;
	Tue, 17 Jan 2012 17:30:02 +0000 (UTC)
Received: from a91-153-116-96.elisa-laajakaista.fi
	(a91-153-116-96.elisa-laajakaista.fi [91.153.116.96])
	by gw02.mail.saunalahti.fi (Postfix) with SMTP id BEE411398B6;
	Tue, 17 Jan 2012 19:10:33 +0200 (EET)
Date: Tue, 17 Jan 2012 19:10:31 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: Kevin Lo <kevlo@FreeBSD.org>
Message-ID: <20120117171031.GA2316@a91-153-116-96.elisa-laajakaista.fi>
References: <201201170125.q0H1PrlJ061058@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201201170125.q0H1PrlJ061058@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r230252 - head/sys/fs/tmpfs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2012 17:30:03 -0000

On 2012-01-17, Kevin Lo wrote:
>   Return EOPNOTSUPP since we only support update mounts for NFS export.
>   
> @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp)
>  		return (EINVAL);
>  
>  	if (mp->mnt_flag & MNT_UPDATE) {
> +		/*
> +		 * Only support update mounts for NFS export.
> +		 */
>  		if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
>  			return (0);
> +		return (EOPNOTSUPP);
>  	}

This doesn't look correct. As long as the option list includes the
"export" option, all options are accepted. An example:

# mount -u -o ro /mnt
mount: tmpfs : Operation not supported
# mount -u -o ro,export /mnt
#

-- 
Jaakko