From owner-svn-src-stable-11@freebsd.org Thu Mar 29 01:17:08 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F449F5F574; Thu, 29 Mar 2018 01:17:08 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 857036E40D; Thu, 29 Mar 2018 01:17:07 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w2T1H3Iu059993; Wed, 28 Mar 2018 18:17:03 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w2T1H3lt059992; Wed, 28 Mar 2018 18:17:03 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803290117.w2T1H3lt059992@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi... In-Reply-To: To: Kyle Evans Date: Wed, 28 Mar 2018 18:17:03 -0700 (PDT) CC: Allan Jude , Oliver Pinter , Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 01:17:08 -0000 [ Charset UTF-8 unsupported, converting... ] > On Wed, Mar 28, 2018 at 8:04 PM, Allan Jude wrote: > > On 2018-03-28 14:15, Oliver Pinter wrote: > >> Hi! > >> > >> This part of the MFC is wrong: > >> > >> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 > >> > >> Could you please MFC back the other random related changes too? Some > >> of them made by cem@. > >> > >> On 3/14/18, Eitan Adler wrote: > >>> Author: eadler > >>> Date: Wed Mar 14 03:19:51 2018 > >>> New Revision: 330897 > >>> URL: https://svnweb.freebsd.org/changeset/base/330897 > >>> > >>> Log: > >>> Partial merge of the SPDX changes > >>> > >>> These changes are incomplete but are making it difficult > >>> to determine what other changes can/should be merged. > >>> > >>> No objections from: pfg > >>> > > Am I missing something? If this MFC was supposed to be of the SPDX > > license tagging, why does it have any functional changes? > > > > Especially changes to random(4)? > > For extra fun, it also had some ARM driver changes that had broken the > VERSATILE kernels, as I recall. gonzo@ took care of MFC'ing the other > parts needed for those, though. It does make me wonder what else was > overlooked, but the commit was large enough that it's not fun to > glance over. I have an audit report coming out in a few minutes that makes it clear what the non SPDX bits are, I belive we can clean this up with a few rXXXXXX reverts in short order. -- Rod Grimes rgrimes@freebsd.org