Date: Wed, 14 Jan 2015 17:01:03 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196729] [patch] multimedia/gstreamer - fix too late occurrence of USES= Message-ID: <bug-196729-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196729 Bug ID: 196729 Summary: [patch] multimedia/gstreamer - fix too late occurrence of USES= Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: multimedia@FreeBSD.org Reporter: z7dr6ut7gs@snkmail.com Assignee: multimedia@FreeBSD.org Flags: maintainer-feedback?(multimedia@FreeBSD.org) Created attachment 151628 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151628&action=edit fix too late USES= by replacing bsd.port.pre.mk with bsd.port.options.mk Adding USES settings after bsd.port.pre.mk causes some variables to be set too late (e.g., *_DEPENDS in Uses/gettext*.mk). For example: before (in current gstreamer port - 0.10.36_2): make -V BUILD_DEPENDS bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf /usr/local/bin/flex:/usr/ports/textproc/flex after patch: make -f Makefile -V BUILD_DEPENDS /usr/local/bin/flex:/usr/ports/textproc/flex bison:/usr/ports/devel/bison gmake:/usr/ports/devel/gmake pkgconf:/usr/ports/devel/pkgconf msgfmt:/usr/ports/devel/gettext-tools Note missing gettext-tools in dependency list before the fix. Bumping PORTREVISION is debatable here, but if the package is not rebuilt, it can have incomplete dependencies (because of missed recording of devel/gettext-runtime in LIB_DEPENDS). It's probably best to bump PORTREVISION, although I did not do so in the attached patch. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer multimedia@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196729-13>