From owner-svn-src-all@FreeBSD.ORG Fri Sep 11 00:00:23 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 971AC1065676; Fri, 11 Sep 2009 00:00:23 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 865378FC08; Fri, 11 Sep 2009 00:00:23 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n8B00Nh8035178; Fri, 11 Sep 2009 00:00:23 GMT (envelope-from jfv@svn.freebsd.org) Received: (from jfv@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n8B00N5C035175; Fri, 11 Sep 2009 00:00:23 GMT (envelope-from jfv@svn.freebsd.org) Message-Id: <200909110000.n8B00N5C035175@svn.freebsd.org> From: Jack F Vogel Date: Fri, 11 Sep 2009 00:00:23 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r197084 - head/sys/dev/ixgbe X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 00:00:23 -0000 Author: jfv Date: Fri Sep 11 00:00:23 2009 New Revision: 197084 URL: http://svn.freebsd.org/changeset/base/197084 Log: Stats missed packet handling was still not quite right, thanks to Dmitrij Tejblum for the correction, need a variable with scope only within the for loop for all queues. MFC: 3 days Modified: head/sys/dev/ixgbe/ixgbe.c Modified: head/sys/dev/ixgbe/ixgbe.c ============================================================================== --- head/sys/dev/ixgbe/ixgbe.c Thu Sep 10 23:30:13 2009 (r197083) +++ head/sys/dev/ixgbe/ixgbe.c Fri Sep 11 00:00:23 2009 (r197084) @@ -4480,9 +4480,11 @@ ixgbe_update_stats_counters(struct adapt adapter->stats.crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS); for (int i = 0; i < 8; i++) { + u32 mp; + mp = IXGBE_READ_REG(hw, IXGBE_MPC(i)); /* missed_rx tallies misses for the gprc workaround */ - missed_rx += IXGBE_READ_REG(hw, IXGBE_MPC(i)); - adapter->stats.mpc[i] += missed_rx; + missed_rx += mp; + adapter->stats.mpc[i] += mp; /* Running comprehensive total for stats display */ total_missed_rx += adapter->stats.mpc[i]; if (hw->mac.type == ixgbe_mac_82598EB)