From owner-svn-src-head@freebsd.org Sun Sep 1 21:12:15 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5D34E62DF; Sun, 1 Sep 2019 21:12:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M5Wg5Fngz3MDZ; Sun, 1 Sep 2019 21:12:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f45.google.com with SMTP id b136so1248002iof.3; Sun, 01 Sep 2019 14:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=iB8ZWtNm7LVbmTxrXHxyHiQjRgroNaSdbiY5Vrukxzg=; b=tG6yxgX2otQf+/NlHwQ0swrHf7pG4w4svmV0wX/h76B7mfBZ6Dzg8PUvyNcEusGyCi MLqZGrTh4Y9LUyfMDhg8SMdIyJsHdSY8IUa4b+Wd0HAxYLNgPW/5WsKRALnuzSwYcWeL ZpV0tHInQ/AjpueAZwqk5VBifkm5rEW+W3tVGbPuwsXo+Ewg8BW+1AbI9l71K8E+1fYD W1YdxlhW5gaLtSYnmVIwqp0i/e0N1g09tedES2ccWJKFImM8Gn4bTwl07YPfdP3dwAN4 0ZRjJ+Aeory9o+IlT4AUDjHb0+BjhE5clzTgYEG5HBKJqvvpdWamdYdfso20xTcBkBL7 9TpA== X-Gm-Message-State: APjAAAW/eBND7pxZfdBe0WiJBh1sKNQzvQ1TeOCtqBE0ehSmb2lVPZS6 hlPPMdgY1ahwgAWzoGvQ+lnCsIXR X-Google-Smtp-Source: APXvYqyHbzBbX/h178mF2hZ7faJtMuxbfcHZ0UYRBQp5TKEbdPST9+sjSX5VQMqLHqDQASo+3wl2Hg== X-Received: by 2002:a5d:81ce:: with SMTP id t14mr9544070iol.97.1567372334177; Sun, 01 Sep 2019 14:12:14 -0700 (PDT) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com. [209.85.166.41]) by smtp.gmail.com with ESMTPSA id v12sm13819272ios.16.2019.09.01.14.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 14:12:13 -0700 (PDT) Received: by mail-io1-f41.google.com with SMTP id j4so25315925iog.11; Sun, 01 Sep 2019 14:12:13 -0700 (PDT) X-Received: by 2002:a5d:8f86:: with SMTP id l6mr2826243iol.270.1567372333725; Sun, 01 Sep 2019 14:12:13 -0700 (PDT) MIME-Version: 1.0 References: <201909011612.x81GC5DW097846@repo.freebsd.org> In-Reply-To: <201909011612.x81GC5DW097846@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sun, 1 Sep 2019 14:12:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio To: Ed Maste Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46M5Wg5Fngz3MDZ X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 21:12:15 -0000 On Sun, Sep 1, 2019 at 9:12 AM Ed Maste wrote: > > Author: emaste > Date: Sun Sep 1 16:12:05 2019 > New Revision: 351659 > URL: https://svnweb.freebsd.org/changeset/base/351659 > > Log: > libc: remove gets > > gets is unsafe and shouldn't be used (for many years now). Leave it in > the existing symbol version so anything that previously linked aginst it > still runs, but do not allow new software to link against it. > ... > Differential Revision: https://reviews.freebsd.org/D12298 Thanks, Ed! I think I saw someone mention some incarnation of standard C++ removes gets(), but to add context from the standard C side: it was present, but obsolete and deprecated, in C99; and was removed in C11. Best, Conrad