From owner-freebsd-bugs@FreeBSD.ORG  Tue Sep 24 12:30:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A5E842D8
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 24 Sep 2013 12:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 937C82930
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Tue, 24 Sep 2013 12:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8OCU1WM026542
 for <freebsd-bugs@freefall.freebsd.org>; Tue, 24 Sep 2013 12:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8OCU1md026541;
 Tue, 24 Sep 2013 12:30:01 GMT (envelope-from gnats)
Date: Tue, 24 Sep 2013 12:30:01 GMT
Message-Id: <201309241230.r8OCU1md026541@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/182161: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2013 12:30:01 -0000

The following reply was made to PR kern/182161; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/182161: commit references a PR
Date: Tue, 24 Sep 2013 12:24:55 +0000 (UTC)

 Author: kib
 Date: Tue Sep 24 12:24:48 2013
 New Revision: 255844
 URL: http://svnweb.freebsd.org/changeset/base/255844
 
 Log:
   Ensure that the ERESTART return from the syscall reloads the
   registers, to make the restarted syscall instruction pass the correct
   arguments.
   
   PR:	kern/182161
   Reported by:	Russ Cox <rsc@swtch.com>
   Sponsored by:	The FreeBSD Foundation
   MFC after:	3 days
   Approved by:	re (marius)
 
 Modified:
   head/sys/amd64/amd64/vm_machdep.c
 
 Modified: head/sys/amd64/amd64/vm_machdep.c
 ==============================================================================
 --- head/sys/amd64/amd64/vm_machdep.c	Tue Sep 24 11:49:04 2013	(r255843)
 +++ head/sys/amd64/amd64/vm_machdep.c	Tue Sep 24 12:24:48 2013	(r255844)
 @@ -400,9 +400,13 @@ cpu_set_syscall_retval(struct thread *td
  		 * for the next iteration.
  		 * %r10 restore is only required for freebsd/amd64 processes,
  		 * but shall be innocent for any ia32 ABI.
 +		 *
 +		 * Require full context restore to get the arguments
 +		 * in the registers reloaded at return to usermode.
  		 */
  		td->td_frame->tf_rip -= td->td_frame->tf_err;
  		td->td_frame->tf_r10 = td->td_frame->tf_rcx;
 +		set_pcb_flags(td->td_pcb, PCB_FULL_IRET);
  		break;
  
  	case EJUSTRETURN:
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"