From owner-freebsd-bugs@FreeBSD.ORG  Thu Jul  1 17:50:07 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3161D1065676
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  1 Jul 2010 17:50:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2136D8FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  1 Jul 2010 17:50:07 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o61Ho7EN063033
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 1 Jul 2010 17:50:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o61Ho7cd063032;
	Thu, 1 Jul 2010 17:50:07 GMT (envelope-from gnats)
Date: Thu, 1 Jul 2010 17:50:07 GMT
Message-Id: <201007011750.o61Ho7cd063032@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/148087: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jul 2010 17:50:07 -0000

The following reply was made to PR kern/148087; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/148087: commit references a PR
Date: Thu,  1 Jul 2010 17:46:25 +0000 (UTC)

 Author: des
 Date: Thu Jul  1 17:44:33 2010
 New Revision: 209632
 URL: http://svn.freebsd.org/changeset/base/209632
 
 Log:
   If the A flag is supplied, http_request() will attempt the request only
   once, even if authentication is required, instead of retrying with the
   proper credentials.  Fix this by bumping the countdown if the origin or
   proxy server requests authentication so that the initial unauthenticated
   request does not count as an attempt.
   
   PR:		148087
   Submitted by:	Tom Evans <tevans.uk@googlemail.com>
   MFC after:	2 weeks
 
 Modified:
   head/lib/libfetch/http.c
 
 Modified: head/lib/libfetch/http.c
 ==============================================================================
 --- head/lib/libfetch/http.c	Thu Jul  1 15:23:29 2010	(r209631)
 +++ head/lib/libfetch/http.c	Thu Jul  1 17:44:33 2010	(r209632)
 @@ -1786,12 +1786,14 @@ http_request(struct url *URL, const char
  			case hdr_www_authenticate:
  				if (conn->err != HTTP_NEED_AUTH)
  					break;
 -				http_parse_authenticate(p, &server_challenges);
 +				if (http_parse_authenticate(p, &server_challenges))
 +					++n;
  				break;
  			case hdr_proxy_authenticate:
  				if (conn->err != HTTP_NEED_PROXY_AUTH)
  					break;
 -				http_parse_authenticate(p, &proxy_challenges);
 +				if (http_parse_authenticate(p, &proxy_challenges) == 0);
 +					++n;
  				break;
  			case hdr_end:
  				/* fall through */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"