Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Jan 2015 01:30:12 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 196947] [new port] devel/py-pcre: Python PCRE Library
Message-ID:  <bug-196947-13-a0ErWyo0Rj@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-196947-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-196947-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196947

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs@FreeBSD. |python@FreeBSD.org
                   |org                         |
             Status|New                         |Open
                 CC|                            |koobs@FreeBSD.org
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa, patch

--- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> ---
Thanks for your submission Maxim. On initial review:

- PORTNAME must match upstream name (python-pcre)
- py- in PORTNAME should be removed, and PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}
added instead
- python is missing as a second entry for CATEGORIES
- Add LICENSE_FILE is one exists in ${WRKSRC}
- GH_PROJECT defaults to ${PORTNAME} which wont be needed after the above
PORTNAME change
- Sort USE_PYTHON values alphabetically
- MAINTAINER is in the wrong location
- WWW: entry is missing in pkg-descr (don't include a trailing slash)
- There are a number of other Makefile entry order issues (portlint will tell
you)

Please also:

- Attach portlint -AC output (after addressing any outstanding issues)
- Attach successful poudriere build output. If you dont have poudriere, you can
attach output of the following instead:

make stage && make check-plist && make stage-qa && make package

Bonus:

- Include (attach) python unit test output
- Create an issue upstream asking the author to upload the package to PyPi
(under name python-pcre)

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196947-13-a0ErWyo0Rj>