From nobody Wed Aug 14 13:51:05 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WkV5p4vYHz5S9gw for ; Wed, 14 Aug 2024 13:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WkV5p3jkwz4jkn for ; Wed, 14 Aug 2024 13:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723643470; a=rsa-sha256; cv=none; b=RM7AFTEwI+0niz5DcFObGwgHbTTplM6IvqBijto20R7BEKYuC4t4+M2cOCZOyPwSXySpN2 DofYTfjTeoqvNS9O6vggYY1gMVen9kScLMrmch3LaB+W/tFVQfVdR/AgJXeC6PTmdEV1yK hpHxaOSQSyMv7qy/g9yXHg2e7JPEZD/HhTuQfrS48eWYrtljnBOMHAIMtXJpeQzrD8B+UU Zhi/I5ITLVkKhZg2fExVyE4jPoGo+kY1QY5CaWPde1HnRwpy9aPFtUOMI9gxc0utiPxL+l jVZpkHq5W9fXFPK6eA/x+WRK/CYTGIfgF0DKv7dt232+oD0Ks1F78uvlktkdLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723643470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SM7fXLZFBQecU+YbeS4IjmnVtLx8hAncN2UmKj7cgjA=; b=Pv+g+96uzvgaXpKv7+4Lsly2cYXgsbkzNmMgUdbmOigvLPX2hD0//QSz5YEiWRT3DUdELO OSGKrU0XoPfdxPt+FV3j2ugA7IosjCMoNo7W9rmvY6ehAXG4HdiMCjrbcoJmnDY2Hx3Edn Zwjq2t5FRFaY/Qq3bzAUOl8wPIQzNLGk5zGZrgkXNyZIt8GuQfHo+E5OnDbY0ThylwxN2f tYYhe6TKU3QAtby/t6c3JBA2kTLZB/AkXWKbbp0FMrPILrWX4G51CIyYYV6k03Jq9avHvc gtPOvs3OMY13RWaiCuFI0qfyJq2tOHQfgI1koOt9OOa66jOtc33GnXjYS7Bhbg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WkV5p3FbjzwvJ for ; Wed, 14 Aug 2024 13:51:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47EDpAe8039159 for ; Wed, 14 Aug 2024 13:51:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47EDpA1J039158 for net@FreeBSD.org; Wed, 14 Aug 2024 13:51:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Wed, 14 Aug 2024 13:51:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #19 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D89f6723288b0d27d3f14f93e6e83f672f= a2b8aca commit 89f6723288b0d27d3f14f93e6e83f672fa2b8aca Author: Kristof Provost AuthorDate: 2024-08-14 09:29:30 +0000 Commit: Kristof Provost CommitDate: 2024-08-14 12:15:07 +0000 pf: invert direction for inner icmp state lookups (e.g. traceroute with icmp) ok henning, jsing Also extend the test case to cover this scenario. PR: 280701 Obtained from: OpenBSD MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") sys/netpfil/pf/pf.c | 21 +++++++++++---------- tests/sys/netpfil/pf/icmp.sh | 4 +++- tests/sys/netpfil/pf/icmp6.sh | 4 +++- 3 files changed, 17 insertions(+), 12 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=