From owner-svn-src-head@freebsd.org  Fri Mar 20 16:31:07 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 14DDC26BFC8;
 Fri, 20 Mar 2020 16:31:07 +0000 (UTC)
 (envelope-from markj@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48kTmS6qyZz44fF;
 Fri, 20 Mar 2020 16:31:04 +0000 (UTC)
 (envelope-from markj@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 897BE26546;
 Fri, 20 Mar 2020 16:24:06 +0000 (UTC)
 (envelope-from markj@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 02KGO6Df077991;
 Fri, 20 Mar 2020 16:24:06 GMT (envelope-from markj@FreeBSD.org)
Received: (from markj@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id 02KGO6pk077990;
 Fri, 20 Mar 2020 16:24:06 GMT (envelope-from markj@FreeBSD.org)
Message-Id: <202003201624.02KGO6pk077990@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: markj set sender to
 markj@FreeBSD.org using -f
From: Mark Johnston <markj@FreeBSD.org>
Date: Fri, 20 Mar 2020 16:24:06 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r359172 - head/contrib/elftoolchain/libdwarf
X-SVN-Group: head
X-SVN-Commit-Author: markj
X-SVN-Commit-Paths: head/contrib/elftoolchain/libdwarf
X-SVN-Commit-Revision: 359172
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2020 16:31:07 -0000

Author: markj
Date: Fri Mar 20 16:24:06 2020
New Revision: 359172
URL: https://svnweb.freebsd.org/changeset/base/359172

Log:
  libdwarf: Make an out-pointer assignment unconditional.
  
  There is no reason for diep to ever be NULL, since in that case we would
  simply be leaking memory.
  
  CID:		1418801
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/contrib/elftoolchain/libdwarf/libdwarf_die.c

Modified: head/contrib/elftoolchain/libdwarf/libdwarf_die.c
==============================================================================
--- head/contrib/elftoolchain/libdwarf/libdwarf_die.c	Fri Mar 20 16:18:54 2020	(r359171)
+++ head/contrib/elftoolchain/libdwarf/libdwarf_die.c	Fri Mar 20 16:24:06 2020	(r359172)
@@ -70,8 +70,7 @@ _dwarf_die_add(Dwarf_CU cu, uint64_t offset, uint64_t 
 	die->die_cu	= cu;
 	die->die_dbg	= cu->cu_dbg;
 
-	if (diep != NULL)
-		*diep = die;
+	*diep = die;
 
 	return (DW_DLE_NONE);
 }