From owner-p4-projects@FreeBSD.ORG  Sun Mar 23 03:47:59 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3D9B71065676; Sun, 23 Mar 2008 03:47:59 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D42F11065670
	for <perforce@freebsd.org>; Sun, 23 Mar 2008 03:47:58 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id C426F8FC1A
	for <perforce@freebsd.org>; Sun, 23 Mar 2008 03:47:58 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m2N3lwis071332
	for <perforce@freebsd.org>; Sun, 23 Mar 2008 03:47:58 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m2N3lwW7071326
	for perforce@freebsd.org; Sun, 23 Mar 2008 03:47:58 GMT
	(envelope-from jb@freebsd.org)
Date: Sun, 23 Mar 2008 03:47:58 GMT
Message-Id: <200803230347.m2N3lwW7071326@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 138327 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Mar 2008 03:47:59 -0000

http://perforce.freebsd.org/chv.cgi?CH=138327

Change 138327 by jb@jb_freebsd1 on 2008/03/23 03:47:53

	Ensure the sync includes the current CPU.
	
	Fix the bug where the current CPU would get called twice,

Affected files ...

.. //depot/projects/dtrace/src/sys/kern/subr_smp.c#13 edit

Differences ...

==== //depot/projects/dtrace/src/sys/kern/subr_smp.c#13 (text+ko) ====

@@ -376,7 +376,7 @@
 	mtx_lock_spin(&smp_ipi_mtx);
 
 	/* set static function pointers */
-	smp_rv_cpumask = map & ~(1 << curcpu);
+	smp_rv_cpumask = map;
 	smp_rv_setup_func = setup_func;
 	smp_rv_action_func = action_func;
 	smp_rv_teardown_func = teardown_func;
@@ -386,11 +386,10 @@
 	atomic_store_rel_int(&smp_rv_waiters[0], 0);
 
 	/* signal other processors, which will enter the IPI with interrupts off */
-	ipi_selected(map, IPI_RENDEZVOUS);
+	ipi_selected(map & ~(1 << curcpu), IPI_RENDEZVOUS);
 
 	/* Check if the current CPU is in the map */
 	if ((map & (1 << curcpu)) != 0)
-		/* call executor function for the current CPU */
 		smp_rendezvous_action();
 
 	if (teardown_func == smp_no_rendevous_barrier)