From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 14 22:00:15 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AEE8106567B for ; Wed, 14 Jul 2010 22:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 82D7F8FC28 for ; Wed, 14 Jul 2010 22:00:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6EM0EAX066632 for ; Wed, 14 Jul 2010 22:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6EM0EHE066631; Wed, 14 Jul 2010 22:00:14 GMT (envelope-from gnats) Resent-Date: Wed, 14 Jul 2010 22:00:14 GMT Resent-Message-Id: <201007142200.o6EM0EHE066631@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anonymous Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0BFA1065677 for ; Wed, 14 Jul 2010 21:52:28 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5E82C8FC12 for ; Wed, 14 Jul 2010 21:52:27 +0000 (UTC) Received: by bwz12 with SMTP id 12so77535bwz.13 for ; Wed, 14 Jul 2010 14:52:27 -0700 (PDT) Received: by 10.204.19.83 with SMTP id z19mr13891929bka.43.1279144347103; Wed, 14 Jul 2010 14:52:27 -0700 (PDT) Received: from localhost ([61.32.46.3]) by mx.google.com with ESMTPS id g11sm2350260bkw.10.2010.07.14.14.52.22 (version=SSLv3 cipher=RC4-MD5); Wed, 14 Jul 2010 14:52:26 -0700 (PDT) Message-Id: <868w5d68af.fsf@gmail.com> Date: Thu, 15 Jul 2010 01:52:08 +0400 From: Anonymous To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/148607: [patch] graphics/zathura: respect STRIP, make build verbose by default X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 22:00:15 -0000 >Number: 148607 >Category: ports >Synopsis: [patch] graphics/zathura: respect STRIP, make build verbose by default >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 14 22:00:13 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Anonymous >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: >Description: - drop USE_GMAKE (adapt include config.mk and $(shell...)) - respect DEBUG_FLAGS rather than DFLAGS, currently any flag (e.g. `-ggdb3') in DEBUG_FLAGS or CFLAGS is being overriden by DFLAGS' `-g' - use PTHREAD_LIBS instead of -lpthread - no need to specify -lc when no -nostdlib is used - make build target verbose, options target doesn't show what flags are used when linking - make install target verbose, so the user know what's being installed - use CFLAGS when linking, too; makes things like -flto in CFLAGS work - add extra tab to MAN1 (cosmetic) >How-To-Repeat: >Fix: --- a.diff begins here --- Index: graphics/zathura/Makefile =================================================================== RCS file: /a/.cvsup/ports/graphics/zathura/Makefile,v retrieving revision 1.1 diff -u -p -r1.1 Makefile --- graphics/zathura/Makefile 5 Jul 2010 17:36:12 -0000 1.1 +++ graphics/zathura/Makefile 14 Jul 2010 21:46:19 -0000 @@ -16,13 +16,28 @@ COMMENT= Customizable lightweight pdf vi LIB_DEPENDS= poppler-glib.4:${PORTSDIR}/graphics/poppler-gtk \ cairo.2:${PORTSDIR}/graphics/cairo -USE_GMAKE= yes USE_GNOME= glib20 gtk20 -MAN1= zathura.1 + +MAN1= zathura.1 MANCOMPRESSED= no PLIST_FILES= bin/zathura -post-patch: - @${REINPLACE_CMD} -e 's|man1|man/man1|g' ${WRKSRC}/Makefile +post-patch: .SILENT + ${REINPLACE_CMD} -e 's|man1|man/man1|g' \ + -e '/CC/s/-s[[:space:]]/${STRIP} /' \ + -e '/CFLAGS/!s/$${LDFLAGS}/$${CFLAGS} &/' \ + -e 's/{DFLAGS/{DEBUG_FLAGS/g' \ + -e 's/755/${BINMODE}/' \ + -e 's/644/${MANMODE}/' \ + -e '/echo[[:space:]]CC/d' \ + -e '/echo/!s/@//' \ + -e '/^all:/s/options//' \ + -e 's/\(include\)[[:space:]]\(.*\)/.\1 "\2"/' \ + ${WRKSRC}/Makefile + ${REINPLACE_CMD} -e 's|/usr/include|${LOCALBASE}/include|' \ + -e 's/-lpthread/${PTHREAD_LIBS}/' \ + -e 's/-lc//' \ + -e 's/$$(shell[[:space:]]\(.*\))/`\1`/' \ + ${WRKSRC}/config.mk .include --- a.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: